Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.12.0 Regression: Cypress.dom.isVisible change in behaviour #8998

Closed
ElisaDellaC opened this issue Oct 28, 2020 · 3 comments · Fixed by #9412
Closed

4.12.0 Regression: Cypress.dom.isVisible change in behaviour #8998

ElisaDellaC opened this issue Oct 28, 2020 · 3 comments · Fixed by #9412
Labels
pkg/driver This is due to an issue in the packages/driver directory type: regression A bug that didn't appear until a specific Cy version release v4.12.0 🐛 Issue present since 4.12.0

Comments

@ElisaDellaC
Copy link

ElisaDellaC commented Oct 28, 2020

We have a scrollable dropdown list and our test wants to verify how many elements are visible when opening the list: to do so we use Cypress.dom.isVisible

Until Cypress version 4.11.0 our test were working as expected: Cypress.dom.isVisible was only detecting as visible the elements of the list that were visible on screen when opening the list and as not visible the ones present in the list but for which you need to scroll down in order to see them displayed on screen.

As from Cypress version 4.12.0, when opening the dropdown list all elements in the list are detected as visible.

If this is a wanted change in behaviour, could you please advise on a workaround to have our test working?

Here a reproduction scenario:
https://github.com/rosahealth/cypress-tiny-test-fork

Many thanks!

@jennifer-shehane
Copy link
Member

I can recreate this behavior using the example in https://github.com/rosahealth/cypress-tiny-test-fork This is a regression in 4.12.0

This was introduced in this PR: #8095 I git bisected and saw the issue was introduced in this commit 298612b

4.11.0

Screen Shot 2020-10-28 at 5 29 40 PM

4.12.0

Screen Shot 2020-10-28 at 5 28 37 PM

@jennifer-shehane jennifer-shehane added v4.12.0 🐛 Issue present since 4.12.0 type: regression A bug that didn't appear until a specific Cy version release labels Oct 28, 2020
@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Oct 28, 2020
@jennifer-shehane jennifer-shehane added internal-priority pkg/driver This is due to an issue in the packages/driver directory labels Oct 28, 2020
@sync-by-unito sync-by-unito bot changed the title Cypress.dom.isVisible change in behaviour as from Cypress versions > 4.11.0 4.12.0 Regression: Cypress.dom.isVisible change in behaviour Oct 28, 2020
@cypress-bot cypress-bot bot added stage: work in progress There is an open PR for this issue [WIP] stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope stage: work in progress There is an open PR for this issue [WIP] labels Dec 2, 2020
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Dec 2, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 2, 2020

The code for this is done in cypress-io/cypress#9412, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@bahmutov
Copy link
Contributor

bahmutov commented Apr 7, 2021

released in v6.1.0

@cypress-io cypress-io locked as resolved and limited conversation to collaborators Apr 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg/driver This is due to an issue in the packages/driver directory type: regression A bug that didn't appear until a specific Cy version release v4.12.0 🐛 Issue present since 4.12.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants