Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility: Copy to clipboard buttons in Cypress GUI #9002

Closed
kevcodez opened this issue Oct 28, 2020 · 2 comments · Fixed by #9003
Closed

Accessibility: Copy to clipboard buttons in Cypress GUI #9002

kevcodez opened this issue Oct 28, 2020 · 2 comments · Fixed by #9003
Labels
pkg/desktop-gui type: enhancement Requested enhancement of existing feature

Comments

@kevcodez
Copy link
Contributor

kevcodez commented Oct 28, 2020 •
edited

What would you like?

To improve accessibility, it would be great if I could quickly copy the Project Id JSON and the Record Key command (in the desktop GUI under Settings) by simply clicking once.

Why is this needed?

This is needed to improve accessibility. This way, it is no longer necessary to manually select and copy the text.

I'll gladly contribute and implement this.
kevcodez added a commit to kevcodez/cypress that referenced this issue Oct 28, 2020
@kevcodez
feat: Copy to clipboard button for settings in desktop GUI
265ee52 
Adds the copy to clipboard function for the Project Id JSON and the Record Key

Addresses cypress-io#9002
@kevcodez kevcodez mentioned this issue Oct 28, 2020
Merged
5 tasks
@cypress-bot cypress-bot bot added the stage: work in progress There is an open PR for this issue [WIP] label Oct 28, 2020
@jennifer-shehane jennifer-shehane added type: enhancement Requested enhancement of existing feature pkg/desktop-gui labels Oct 29, 2020
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: work in progress There is an open PR for this issue [WIP] and removed stage: work in progress There is an open PR for this issue [WIP] stage: needs review The PR code is done & tested, needs review labels Nov 2, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 3, 2020

The code for this is done in cypress-io/cypress#9003, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot added stage: pending release There is a closed PR for this issue and removed stage: work in progress There is an open PR for this issue [WIP] labels Nov 3, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 9, 2020

Released in 5.6.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v5.6.0, please open a new issue.

@cypress-bot cypress-bot bot removed the stage: pending release There is a closed PR for this issue label Nov 9, 2020
@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Nov 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
pkg/desktop-gui type: enhancement Requested enhancement of existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Copy to clipboard button for settings/runs in desktop GUI kevcodez/cypress
2 participants
@jennifer-shehane @kevcodez