Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.12.0 Regression: Using cypress does not display success message when using open #9031

Closed
karinecord opened this issue Oct 29, 2020 · 4 comments · Fixed by #9412
Closed
Labels
pkg/driver This is due to an issue in the packages/driver directory type: regression A bug that didn't appear until a specific Cy version release v4.12.0 🐛 Issue present since 4.12.0

Comments

@karinecord
Copy link

karinecord commented Oct 29, 2020

Hi,
While I was writing a test to verify if a message is displayed, I've noticed that cypress is behaving strangely.
When the app form is submitted, it should display a success messsage, but on v4.12.0 does not display.
Initially, I've thought it would be the app I was testing, but when I submit the form manually it displays as expected.
Started with v5.3.0, than I've figured that until version 4.11.0 it works fine, but from 4.12.0 the issue begins.

Cypress 4.11.0
test-message-v4 11 0

Cypress 4.12.0
test-message-4 12 0

It's strange because it fails only when using cypress open.
Using cypress run or cypress run --browser chrome works fine. Plus, the console displays loads of GET requests.

Here it's the code that reproduces the issue https://github.com/karinecord/cypress-regression-test

npm install
./node_modules/.bin/cypress open

Doing the code below the test pass:

npm uninstall cypress --save && npm install cypress@4.11.0 --save
./node_modules/.bin/cypress open

Tecnical details

Browser:
Chrome Version 86.0.4240.75 (Official Build) (64-bit)

OS
Distributor ID: Ubuntu
Description: Ubuntu 18.04.5 LTS
Release: 18.04
Codename: bionic

Node: v10.15.1

@jennifer-shehane jennifer-shehane added v4.12.0 🐛 Issue present since 4.12.0 type: regression A bug that didn't appear until a specific Cy version release labels Oct 30, 2020
@jennifer-shehane
Copy link
Member

I can recreate this issue from the repo provided. This was introduced in 4.12.0 by this PR: #8095

Repro

it('should display sucess message', () => {
  cy.visit('https://opensource-demo.orangehrmlive.com/');

  cy.get('#txtUsername').type('Admin');
  cy.get('#txtPassword').type('admin123');
  cy.get('#btnLogin').click();

  cy.get('#menu_pim_viewMyDetails').click();
  cy.get('#sidenav').contains('Contact Details').click();

  cy.get('#btnSave').click();
  cy.get('#btnSave').click();

  cy.get('.message.success').contains('Successfully Saved').should('be.visible');
});

@jennifer-shehane jennifer-shehane changed the title 4.12.0 Possible Regression: Using cypress does not display success message when using open 4.12.0 Regression: Using cypress does not display success message when using open Oct 30, 2020
@cypress-bot cypress-bot bot added the stage: needs investigating Someone from Cypress needs to look at this label Oct 30, 2020
@jennifer-shehane jennifer-shehane added pkg/driver This is due to an issue in the packages/driver directory internal-priority and removed stage: needs investigating Someone from Cypress needs to look at this labels Oct 30, 2020
@karinecord
Copy link
Author

Great, thanks @jennifer-shehane !

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 2, 2020

The code for this is done in cypress-io/cypress#9412, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@bahmutov
Copy link
Contributor

bahmutov commented Apr 7, 2021

Released in v6.1.0

@cypress-io cypress-io locked as resolved and limited conversation to collaborators Apr 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg/driver This is due to an issue in the packages/driver directory type: regression A bug that didn't appear until a specific Cy version release v4.12.0 🐛 Issue present since 4.12.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants