Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report bundled Node version #9180

Closed
bahmutov opened this issue Nov 12, 2020 · 3 comments · Fixed by #9183
Closed

Report bundled Node version #9180

bahmutov opened this issue Nov 12, 2020 · 3 comments · Fixed by #9183
Assignees
Labels

Comments

@bahmutov
Copy link
Contributor

When building cypress/included:x.y.z Docker image sometimes we miss the Node version and create a Docker image with Node version that does not match the Node version bundled with Cypress. It would be nice to validate the Node version during the CI build process. The problem is we do not output bundled Node version from Cypress.

Proposal:

Extend the cypress version command to output bundled Node version

$ npx cypress version
Cypress package version: 5.4.0
Cypress binary version: 5.4.0
Cypress includes Node: 12.14.1

Stretch goal:

For simple parsing add a parameter to output just a particular version

$ npx cypress version --package
5.4.0
$ npx cypress version --node
12.14.1
@bahmutov
Copy link
Contributor Author

Notes: we read the binary package version from the installed app json file

$ DEBUG=cypress:cli npx cypress version
  cypress:cli NODE_OPTIONS is not set +0ms
  cypress:cli Reading binary package.json from: /Users/gleb/Library/Caches/Cypress/5.4.0/Cypress.app/Contents/Resources/app/package.json +0ms
Cypress package version: 5.4.0
Cypress binary version: 5.4.0
$ cat /Users/gleb/Library/Caches/Cypress/5.4.0/Cypress.app/Contents/Resources/app/package.json
{
  "name": "cypress",
  "productName": "Cypress",
  "description": "Cypress.io end to end testing tool",
  "version": "5.4.0",
  "main": "index.js",
  "env": "production"
}

We could write the bundled Node version into that file too

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 16, 2020

The code for this is done in cypress-io/cypress#9183, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 24, 2020

Released in 6.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v6.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant