New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(net-stubbing): match cy.intercept(url) globs against url+path #14241
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test for passing matchUrlAgainstPath: false
to ensure this will strictly match against the url if set to false?
Should be good to merge after my comments are addressed.
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
User facing changelog
Additional details
matchUrlAgainstPath
property to RouteMatchercy.intercept(url)
fromcy.intercept({ url })
orcy.intercept({ path })
cy.route
behavior by applying a/
prefix to un-prefixedurl
values that are being matched against a path - old behavior:cypress/packages/driver/src/cypress/server.js
Lines 296 to 301 in ad194de
How has the user experience changed?
now works as described in #9379 (comment)
PR Tasks
cypress-documentation
? docs(intercept): document matchUrlAgainstPath cypress-documentation#3424type definitions
?cypress.schema.json
?