Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: guard against non-string keys before showing an error #14593

merged 4 commits into from
Jan 19, 2021


Copy link

@bahmutov bahmutov commented Jan 15, 2021

User facing changelog

Cypress won't crash when running with the command

cypress run --record --key --parallel

Additional details

The argument --key got value "--parallel" when parsing, and then later got cast to become "key: true". Later it crashes the test runner as we were trying to show an error message.

How has the user experience changed?

You will see a good error message

Screen Shot 2021-01-15 at 1 16 37 PM

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?

Copy link

cypress-bot bot commented Jan 15, 2021

Thanks for taking the time to open a PR!

Copy link

cypress bot commented Jan 15, 2021

Test summary

9197 0 118 3

Run details

Project cypress
Status Passed
Commit 1e65ace
Started Jan 15, 2021 6:24 PM
Ended Jan 15, 2021 6:37 PM
Duration 12:51 💡
OS Linux Debian - 10.5
Browser Multiple

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@bahmutov bahmutov changed the title guard against non-string keys before showing an error fix: guard against non-string keys before showing an error Jan 15, 2021
@bahmutov bahmutov marked this pull request as ready for review January 15, 2021 18:17
Copy link

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, well tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Cypress crashes on trying to record with an empty key
2 participants