Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert "fix: use stdio for CDP instead of TCP" #14819

merged 1 commit into from Jan 29, 2021


Copy link

@flotwig flotwig commented Jan 29, 2021

Seems to be causing more issues than good so far - should probably still do this, but need to rethink the error messaging/potentially race TCP/stdio connection.

Reverts #14348

Copy link

cypress-bot bot commented Jan 29, 2021

Thanks for taking the time to open a PR!

Copy link

cypress bot commented Jan 29, 2021

Test summary

9288 0 118 3Flakiness 1

Run details

Project cypress
Status Passed
Commit 58b40f5
Started Jan 29, 2021 3:54 PM
Ended Jan 29, 2021 4:06 PM
Duration 12:12 💡
OS Linux Debian - 10.5
Browser Multiple

View run in Cypress Dashboard ➡️


cypress/integration/retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig flotwig requested a review from kuceb January 29, 2021 16:34
Copy link

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@flotwig flotwig merged commit 0345d1e into develop Jan 29, 2021
62 of 63 checks passed
Copy link

cypress-bot bot commented Feb 1, 2021

Released in 6.4.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v6.4.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Feb 1, 2021
@flotwig flotwig deleted the revert-14348-cdp-pipe branch January 24, 2022 18:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants