New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(component-testing): simplify vue mount #15275
Conversation
Thanks for taking the time to open a PR!
|
We could use the feature that is built in to test utils: https://vue-test-utils.vuejs.org/api/#enableautodestroy-hook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could consider using the version built into test utils: We could use the feature that is built in to test utils: https://vue-test-utils.vuejs.org/api/#enableautodestroy-hook
@lmiller1990 I do not think we can put anything in afterEach without reaching for a support file. Where were you thinking we call this |
I understand after looking at your vite PR what you mean. |
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks okay to me. It's an improvement on where we currently are. There are some fundamental issues with how we are cleaning up, but those will be addressed when we refactor these to use Cypress's internal events.
aae78cb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manually tested this. It's looking good.
e3d152b
to
46f0959
Compare
5cf5ad3
to
e6adfa9
Compare
- Avoid recreating the root element at each test - Make sure we properly destroy the vue instance after each iteration
f03b6e1
to
e8297be
Compare
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
User facing changelog
Fixes some of the memory leaks in with
@cypress/vue
Additional details
This might fix some issues with devtools
PR Tasks