Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(desktop-gui): Align 'plugins' error message to top #15347

Merged
merged 1 commit into from Mar 8, 2021

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Mar 5, 2021

User Changelog

The plugins error message is now top-aligned.

Additional Details

  • This change was introduced in the node-sass PR in 6.3.0.
  • To restore back to the original design, the error message should be veritically centered, but I don't think this is necessary and in fact slightly counter-intuitive since when you expand the error message, the link 'moves' so that you have to move your mouse again to close the expanded error message.
  • Also, vertically centering things in CSS is 馃憥

User Experience changes

Cypress 6.2.0

Before this PR

After this PR

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 5, 2021

Thanks for taking the time to open a PR!

@jennifer-shehane jennifer-shehane changed the title Align error message to top of desktop-gui fix(desktop-gui): Align 'plugins' error message to top Mar 5, 2021
@cypress
Copy link

cypress bot commented Mar 5, 2021



Test summary

9364 0 118 3Flakiness 1


Run details

Project cypress
Status Passed
Commit f373b9b
Started Mar 5, 2021 7:27 PM
Ended Mar 5, 2021 7:38 PM
Duration 11:07 馃挕
OS Linux Debian - 10.5
Browser Multiple

View run in Cypress Dashboard 鉃★笍


Flakiness

cypress/integration/retries.ui.spec.js 1聽Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@chrisbreiding chrisbreiding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Agree that it's much better top-aligned so things don't jump around after expanding/collapsing.

@jennifer-shehane jennifer-shehane merged commit e610e31 into develop Mar 8, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 15, 2021

Released in 6.7.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v6.7.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Mar 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants