Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Response.headers type. #15419

Merged
merged 1 commit into from Mar 16, 2021
Merged

Conversation

sainthkh
Copy link
Contributor

User facing changelog

set-cookie can be string[]. So, the headers type has been changed.

Additional details

  • Why was this change necessary? => Cypress type doesn't reflect the real code.
  • What is affected by this change? => N/A
  • Any implementation details to explain? => N/A

How has the user experience changed?

N/A

PR Tasks

  • Have tests been added/updated?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 11, 2021

Thanks for taking the time to open a PR!

@sainthkh sainthkh marked this pull request as ready for review March 11, 2021 03:17
@sainthkh
Copy link
Contributor Author

Flaky failure.

@flotwig flotwig changed the base branch from develop to 7.0-release March 16, 2021 19:46
@flotwig flotwig added the type: breaking change Requires a new major release version label Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: breaking change Requires a new major release version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong typing for Response.headers that is returned by cy.request
2 participants