chore: switch lolex to new name @sinonjs/fake-timers #15595
Thanks for taking the time to open a PR!
Hi again @chrisbreiding !
There was indeed some errors! I had just run the unit tests locally, which I guess don't cover this part of the code very well as that's maybe more covered in the Cypress tests that were rightly failing.
It seems to all track down to one line in the configuration, which was anyways re-specifying window that had just been passed in to withGlobal, so makes sense that it's deprecated if one could do it in two places before.
The two test failures I see now, npm-react and npm-vue don't seem to have anything to do with this code, and also rely on waiting in real-time it seems so could it maybe be they are flaky? Or does it have something to do with my missing credentials as I'm pulling in from a fork? Don't think this is related to my code, though I'm happy to work on it with some guidance if it is.
I'll also just push another small commit removing a vscode setting disabling formatting I added, so maybe that force of rerunning tests will fix it if they are indeed flaky.
And also I put back the monkey patching name to
* develop: fix flaky e2e record passes test (#16043) chore: switch lolex to new name @sinonjs/fake-timers (#15595) add pwa example (#15970) fix starting cdp screencast when video:false (#15985) fix(deps): update dependency ansi_up to version 5.x 🌟 (#15440) fix: run-ct does not hang on windows anymore (#16022) docs: in vite-dev-server example don't require the config (#15866)