Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove failing imports #15661

Merged
merged 2 commits into from Mar 26, 2021
Merged

fix: remove failing imports #15661

merged 2 commits into from Mar 26, 2021

Conversation

elevatebart
Copy link
Contributor

@elevatebart elevatebart commented Mar 25, 2021

The normalize and fontawesome css files were never succesfully imported.
Nobody complained, and the errors in the command prompts are triggering.
If we want to load normalize in the future, I suggest to do it in a separate PR.

User facing changelog

Errors Refused to apply style are gone from the console in open-ct

Additional details

The two file had @import statements that were left as is during compilation. At runtime, the server tried to reach those files but given the context could not find it.
If these files need to be in the stack it would be nice to inline them.
For now, there is no regression and the error is gone.

If it never worked and nodbody complained it must be useless
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 25, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Mar 26, 2021



Test summary

9407 0 119 3Flakiness 1


Run details

Project cypress
Status Passed
Commit d0be455
Started Mar 26, 2021 12:40 AM
Ended Mar 26, 2021 12:51 AM
Duration 11:07 💡
OS Linux Debian - 10.5
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@lmiller1990 lmiller1990 merged commit 357a296 into develop Mar 26, 2021
@lmiller1990 lmiller1990 deleted the fix/normalize-fontawesome branch March 26, 2021 01:31
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 5, 2021

Released in 7.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Apr 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants