Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improvements to TR -> dashboard linking process #15665

merged 5 commits into from Mar 29, 2021


Copy link

@panzarino panzarino commented Mar 25, 2021

User facing changelog

Minor improvements to the project linking process

Additional details

  • Fix issue where grey background around dashboard selling points did not extend to bottom of screen
    • Updated icons & copy coming soon!
  • Changed 'X' to close to back button
  • Removed horizontal separators between inputs
  • Updated copy on input labels
    • Replaced questions with simple labels
    • Additional clarification as to "new" and "existing"
  • Updated logic for orgs with existing dashboard projects to be more in line with the most likely intended action
    • if all projects have runs -> default to create project
    • if any existing project does not have a run -> default to selecting a project (with those without runs still sorted to the top)
  • Fix flakiness from tests introduced in feat: onboarding prompt for writing first test #15204

Docs (non-blocking) - cypress-io/cypress-documentation#3754

How has the user experience changed?

Select existing project

Screen Shot 2021-03-29 at 11 55 25

Screen Shot 2021-03-29 at 11 54 13

Create a new project

Screen Shot 2021-03-29 at 11 55 18

Screen Shot 2021-03-29 at 11 54 05

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?

Copy link

cypress-bot bot commented Mar 25, 2021

Thanks for taking the time to open a PR!

Copy link

cypress bot commented Mar 25, 2021

Test summary

9409 0 119 3Flakiness 1

Run details

Project cypress
Status Passed
Commit 7d2156d
Started Mar 29, 2021 5:27 PM
Ended Mar 29, 2021 5:38 PM
Duration 11:29 💡
OS Linux Debian - 10.5
Browser Multiple

View run in Cypress Dashboard ➡️


cypress/integration/retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@panzarino panzarino marked this pull request as ready for review March 29, 2021 17:15
Copy link

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good improvements. Manually checked the changes.

@panzarino panzarino merged commit 232bd87 into develop Mar 29, 2021
55 checks passed
Copy link

cypress-bot bot commented Apr 5, 2021

Released in 7.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Apr 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants