Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename delayMs, res.throttle, res.delay #15700

Merged
merged 2 commits into from
Mar 29, 2021

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Mar 29, 2021

  • Closes

User facing changelog

  • BREAKING CHANGE: The res.throttle and res.delay functions on responses yielded to cy.intercept() response handlers have been renamed to res.setThrottle and res.setDelay.

Additional details

How has the user experience changed?

PR Tasks

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 29, 2021

Thanks for taking the time to open a PR!

@jennifer-shehane
Copy link
Member

reverting the reversion! 🙃

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the concept behind this was vetted somewhere upstream. In which case I am approving the code changes purely as doing what you say it does.

@cypress
Copy link

cypress bot commented Mar 29, 2021



Test summary

9505 0 111 3Flakiness 1


Run details

Project cypress
Status Passed
Commit 1c4b279
Started Mar 29, 2021 7:14 PM
Ended Mar 29, 2021 7:25 PM
Duration 11:11 💡
OS Linux Debian - 10.8
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig flotwig merged commit 749b9f1 into 7.0-release Mar 29, 2021
flotwig added a commit to cypress-io/cypress-documentation that referenced this pull request Mar 29, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 5, 2021

Released in 7.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Apr 5, 2021
@flotwig flotwig deleted the cy-intercept-res-setters branch January 24, 2022 18:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants