Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [breaking] remove experimentalComponentTesting and require component tests to be run inside of open-ct #15701

Merged
merged 20 commits into from
Mar 30, 2021

Conversation

JessicaSachs
Copy link
Contributor

@JessicaSachs JessicaSachs commented Mar 29, 2021

This PR requires users migrate from the Cypress E2E Runner to the Cypress Component Test Runner. The addition of the open-ct and run-ct subcommands eliminates the need for a dedicated experimental feature flag (experimentalComponentTesting).

User facing changelog

  • With the addition of a dedicated component testing entrypoint, the experimentalComponentTesting flag has been removed.
  • Projects setting this flag in cypress.json will throw an error, and component tests may only be run within cypress open-ct.
  • Please refer to the Migration Guide for complete migration instructions.

Additional details

The file:preprocessor hook used by the E2E runner to compile specs is incompatible with the new dev-server:start hook used to compile specs. This change was necessary to cut users over to the new dev server architecture.

How has the user experience changed?

  • The Desktop GUI no longer lists component tests
  • Component tests must be run from within the open-ct command.

Before: Cypress CT and E2E tests are listed alongside each other

Screen Shot 2021-03-29 at 4 14 08 PM

After:
Desktop GUI does not display component tests

Screen Shot 2021-03-29 at 4 14 39 PM

Component Test runner displays component tests

Screen Shot 2021-03-29 at 4 14 57 PM

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 29, 2021

Thanks for taking the time to open a PR!

@lmiller1990 lmiller1990 changed the title breaking: remove experimentalComponentTesting and require component tests to be run inside of open-ct feat: [breaking] remove experimentalComponentTesting and require component tests to be run inside of open-ct Mar 30, 2021
@cypress
Copy link

cypress bot commented Mar 30, 2021



Test summary

3983 0 52 1Flakiness 0


Run details

Project cypress
Status Passed
Commit 1ed434c
Started Mar 30, 2021 11:12 PM
Ended Mar 30, 2021 11:23 PM
Duration 10:51 💡
OS Linux Debian - 10.5
Browser Firefox 77

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@lmiller1990
Copy link
Contributor

lmiller1990 commented Mar 30, 2021

@JessicaSachs this is all good now. To confirm you intention was making run-ct and open-ct public?

Also ci/circleci: desktop-gui-component-tests is now gone? Seems CI did not realize.

@agg23
Copy link
Contributor

agg23 commented Mar 30, 2021

Yes @lmiller1990, the exposure of open-ct is intentional

@JessicaSachs JessicaSachs merged commit c7716f2 into develop Mar 30, 2021
@lmiller1990 lmiller1990 deleted the agg23/CTExperimentalDeprecation branch March 30, 2021 23:34
@JessicaSachs JessicaSachs restored the agg23/CTExperimentalDeprecation branch March 30, 2021 23:35
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 5, 2021

Released in 7.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Apr 5, 2021
@emilyrohrbough emilyrohrbough deleted the agg23/CTExperimentalDeprecation branch August 1, 2024 13:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants