Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore template string linting for now #15748

Merged
merged 1 commit into from Apr 1, 2021

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Apr 1, 2021

Merging develop into 7.0-release at this commit is causing lint to crash:

e657481

Lint: https://app.circleci.com/pipelines/github/cypress-io/cypress/18714/workflows/68faf81a-d57a-4944-acc8-97883dc334f8/jobs/677644

Relevant discussions:

Removing template string linting is a temporary fix, until we can devote time to migrate the deprecated babel-eslint to @babel/eslint-parser (#15745, needs work) or find another solution.

@flotwig flotwig requested a review from agg23 April 1, 2021 18:12
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 1, 2021

Thanks for taking the time to open a PR!

@flotwig flotwig changed the title chore:: ignore template string linting for now chore: ignore template string linting for now Apr 1, 2021
@flotwig flotwig merged commit 4a813c9 into 7.0-release Apr 1, 2021
@cypress
Copy link

cypress bot commented Apr 1, 2021



Test summary

9490 0 111 3Flakiness 2


Run details

Project cypress
Status Passed
Commit 1282c70
Started Apr 1, 2021 6:20 PM
Ended Apr 1, 2021 6:32 PM
Duration 11:25 💡
OS Linux Debian - 10.8
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes
specs_list_spec.js Flakiness
1 ... > displays

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig flotwig deleted the fix-template-string-linting branch January 24, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants