Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only log process.emitWarning outside of production #15817

Merged
merged 1 commit into from Apr 6, 2021

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Apr 6, 2021

  • Closes

User facing changelog

  • Fixed an issue introduced in 7.0.0 where certain Node.js warnings were incorrectly printed to stderr in production builds of Cypress.

Additional details

fix for typo in #15723

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 6, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Apr 6, 2021



Test summary

9492 0 111 3Flakiness 1


Run details

Project cypress
Status Passed
Commit 71e5376
Started Apr 6, 2021 5:26 PM
Ended Apr 6, 2021 5:39 PM
Duration 12:55 💡
OS Linux Debian - 10.8
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig flotwig requested a review from bahmutov April 6, 2021 17:39
@flotwig flotwig marked this pull request as ready for review April 6, 2021 17:39
@flotwig flotwig requested a review from a team as a code owner April 6, 2021 17:39
Copy link
Contributor

@bahmutov bahmutov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super

@flotwig flotwig merged commit a962137 into develop Apr 6, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 7, 2021

Released in 7.0.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.0.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Apr 7, 2021
@flotwig flotwig deleted the fix-suppress-warnings branch January 24, 2022 18:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants