Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make the z-index of file opener over the reporter #15831

merged 2 commits into from Apr 7, 2021


Copy link

@elevatebart elevatebart commented Apr 6, 2021

When selecting the preferred editor for opening files in CT, we get the reporter above the dialog.

Using this PR we get the dialog over the command log panel.

User facing changelog

Fixed a z-index issue with "Open in IDE" modal in the Component Test Runner.

How has the user experience changed?


@elevatebart elevatebart requested a review from a team as a code owner April 6, 2021 22:50
Copy link

cypress-bot bot commented Apr 6, 2021

Thanks for taking the time to open a PR!

@lmiller1990 lmiller1990 requested review from lmiller1990 and removed request for a team April 6, 2021 23:17
Copy link

cypress bot commented Apr 6, 2021

Test summary

4017 0 52 1Flakiness 0

Run details

Project cypress
Status Passed
Commit b8d70f7
Started Apr 7, 2021 12:17 AM
Ended Apr 7, 2021 12:29 AM
Duration 11:31 💡
OS Linux Debian - 10.8
Browser Firefox 77

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@lmiller1990 lmiller1990 merged commit 702a152 into develop Apr 7, 2021
53 checks passed
Copy link

cypress-bot bot commented Apr 7, 2021

Released in 7.0.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.0.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Apr 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants