Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runner-ct): fixing an exception and styling #15833

Merged
merged 3 commits into from
Apr 7, 2021

Conversation

JessicaSachs
Copy link
Contributor

@JessicaSachs JessicaSachs commented Apr 6, 2021

  1. When you hit "enter" on the spec list input, an error would appear in the user's command log.
  2. When no devtools were enabled, there was an issue where the component would suddenly un-hide the devtools bar when a new spec was selected. This pushed the AUT up and out of the window
  • Closes

User facing changelog

Fixing a UI issue where an exception was thrown when the user hit "enter" on the spec list input

Additional details

How has the user experience changed?

FIXED: Aut jump

aut-jump.mov

FIXED: Spec List input throws exception in user's command log
Screen Shot 2021-04-06 at 7 03 19 PM

Before: icon spacing too tight
Screen Shot 2021-04-06 at 7 02 25 PM

After: icon spacing better
Screen Shot 2021-04-06 at 7 17 23 PM

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 6, 2021

Thanks for taking the time to open a PR!

@lmiller1990 lmiller1990 self-requested a review April 6, 2021 23:10
Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine

@lmiller1990 lmiller1990 changed the title patch: fixing an exception and styling fix(runner-ct): fixing an exception and styling Apr 6, 2021
@cypress
Copy link

cypress bot commented Apr 6, 2021



Test summary

4017 0 52 1Flakiness 0


Run details

Project cypress
Status Passed
Commit 0ae14d2
Started Apr 7, 2021 1:10 AM
Ended Apr 7, 2021 1:21 AM
Duration 10:59 💡
OS Linux Debian - 10.8
Browser Firefox 77

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@lmiller1990 lmiller1990 merged commit f888625 into develop Apr 7, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 7, 2021

Released in 7.0.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.0.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Apr 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants