Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade lodash types #15860

Merged
merged 1 commit into from Apr 13, 2021

Conversation

emilgoldsmith
Copy link
Contributor

  • Closes

User facing changelog

Upgrade Typescript types for Lodash

Additional details

I encountered a bug in the lodash types that required me to do type assertions, found a fix but when checking the Lodash types I recognized that it had already been fixed, so just upgrading the types here

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@emilgoldsmith emilgoldsmith requested a review from a team as a code owner April 7, 2021 19:39
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 7, 2021

Thanks for taking the time to open a PR!

@emilgoldsmith emilgoldsmith changed the title Upgrade lodash types chore: Upgrade lodash types Apr 7, 2021
@flotwig flotwig merged commit 2390741 into cypress-io:develop Apr 13, 2021
@emilgoldsmith emilgoldsmith deleted the upgrade-lodash-types branch April 19, 2021 15:04
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 26, 2021

Released in 7.2.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.2.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants