Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(desktop-gui): correctly display component and e2e config values #16282

merged 1 commit into from Apr 30, 2021


Copy link

User facing changelog

Fix a bug where e2e and component configuration values were not correctly showing in the Cypress launcher.

Additional details

It looks like in the original PR that implemented this feature, we intentionally removed the component and e2e values when merging the config. This makes the actual cypress.json config and what's shown in the Desktop GUI different, which could be lead to confusion. This PR changes the behavior and leaves the overridden values in the config object, even after merging them based on testingType.

How has the user experience changed?

  • show {} for empty object
  • correctly show e2e overrides:


PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@lmiller1990 lmiller1990 requested a review from a team as a code owner April 30, 2021 03:03
@lmiller1990 lmiller1990 requested review from jennifer-shehane and kuceb and removed request for a team April 30, 2021 03:03
Copy link

cypress-bot bot commented Apr 30, 2021

Thanks for taking the time to open a PR!

@lmiller1990 lmiller1990 requested review from chrisbreiding and removed request for kuceb April 30, 2021 03:03
Copy link

cypress bot commented Apr 30, 2021

Test summary

9518 0 111 3Flakiness 0

Run details

Project cypress
Status Passed
Commit f7ae7be
Started Apr 30, 2021 3:03 AM
Ended Apr 30, 2021 3:15 AM
Duration 11:21 💡
OS Linux Debian - 10.8
Browser Multiple

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of get the initial motivation, but this makes more sense to me to show both objects. I can see the config passed, but also still evaluate what the resolved config is in the main object.

This also used to be weird if you tried to console.log the config object from your plugins file. If you passed a bunch of config to e2e, it would just be empty. That's been fixed also in this PR.

This looks good and is tested. Shouldn't get weird [object Object] in the future also.

Copy link

cypress-bot bot commented May 10, 2021

Released in 7.3.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.3.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

In Desktop GUI, e2e and component in config display as [object Object]
2 participants