Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(desktop-gui): add ci and dashboard prompts with docs dropdown menu #16433

Merged
merged 42 commits into from Jun 7, 2021

Conversation

panzarino
Copy link
Contributor

@panzarino panzarino commented May 11, 2021

User facing changelog

  • Adds a docs dropdown menu to more easily access relevant content

Additional details

Adds some prompts that encourage users to set up their test suite in CI and take advantage of smart orchestration offered by the dashboard.

How has the user experience changed?

Screen Shot 2021-06-08 at 01 46 30

Responsive

Screen Shot 2021-06-08 at 01 46 41

Prompts

Screen Shot 2021-06-07 at 18 25 02

Screen Shot 2021-06-07 at 18 25 17

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 11, 2021

Thanks for taking the time to open a PR!

@panzarino panzarino changed the title Ci dashboard prompts feat(desktop-gui): add ci and dashboard prompts May 11, 2021
@cypress
Copy link

cypress bot commented May 11, 2021



Test summary

4081 0 50 2Flakiness 0


Run details

Project cypress
Status Passed
Commit 3f3daba
Started Jun 7, 2021 1:12 PM
Ended Jun 7, 2021 1:23 PM
Duration 11:03 💡
OS Linux Debian - 10.8
Browser Chrome beta 92

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@panzarino panzarino marked this pull request as ready for review June 4, 2021 01:03
@panzarino panzarino requested a review from a team as a code owner June 4, 2021 01:03
@panzarino panzarino requested review from jennifer-shehane and kuceb and removed request for a team June 4, 2021 01:03
@flotwig flotwig requested review from chrisbreiding and removed request for kuceb June 4, 2021 14:36
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good overall. Some minor feedback. I didn't test if the prompts display 4 days later 😝 , but it does seem there is a test for that.

packages/desktop-gui/src/auth/login-form.jsx Show resolved Hide resolved
packages/desktop-gui/src/prompts/prompts-model.js Outdated Show resolved Hide resolved
packages/desktop-gui/src/prompts/prompts.jsx Outdated Show resolved Hide resolved
packages/desktop-gui/src/prompts/prompts.jsx Outdated Show resolved Hide resolved
packages/desktop-gui/src/prompts/prompts.jsx Outdated Show resolved Hide resolved
packages/desktop-gui/src/prompts/prompts.jsx Outdated Show resolved Hide resolved
packages/desktop-gui/src/prompts/prompts.jsx Show resolved Hide resolved
packages/desktop-gui/src/app/docs-menu.jsx Outdated Show resolved Hide resolved
@jennifer-shehane
Copy link
Member

Some failures in the desktop-gui that need addressing.

@jennifer-shehane
Copy link
Member

Also doesn't look like the Percy build finalized, the new snapshots will need to be approved before this is merged.

@panzarino
Copy link
Contributor Author

panzarino commented Jun 7, 2021

@jennifer-shehane I've implemented a majority of the copy changes that you suggested along with a couple others (suggested in slack by Brian). After these changes I'm going to "lock in" the copy as is (at least until this PR goes live) given how extensively we've reviewed the content in acceptance testing sessions

@panzarino
Copy link
Contributor Author

I've also introduced changes to add utm_content so we can better track if engagement comes from automatic display or manual selection from the dropdown

@panzarino panzarino merged commit 6171fdf into develop Jun 7, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 7, 2021

Released in 7.5.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.5.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants