Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Alphabetize plugin config #16564

merged 3 commits into from May 20, 2021


Copy link

@jennifer-shehane jennifer-shehane commented May 18, 2021

User facing changelog

config in the plugins will now display in alphabetical order.

Additional Details

  • I was trying to look for a specific value in config and it’s just more difficult if everything isn’t alphabetized.
  • Config display won’t be affected by someone putting it in the wrong order (as was the case for the new scrollBehavior config)
  • Will alphabetize config that was pushed in after init (like configFile, projectRoot)
  • I don't think we likely need a specific test for this, since the config will change over time.

How has the user experience changed


Screen Shot 2021-05-18 at 9 59 25 AM


Everything in its right place

Screen Shot 2021-05-18 at 10 04 53 AM

@jennifer-shehane jennifer-shehane requested a review from a team as a code owner May 18, 2021 15:10
@jennifer-shehane jennifer-shehane requested review from chrisbreiding and kuceb and removed request for a team May 18, 2021 15:10
Copy link

cypress-bot bot commented May 18, 2021

Thanks for taking the time to open a PR!

@jennifer-shehane jennifer-shehane marked this pull request as draft May 18, 2021 15:13
@jennifer-shehane jennifer-shehane changed the title Alphabetize plugin config fix: Alphabetize plugin config May 18, 2021
Copy link

cypress bot commented May 18, 2021

Test summary

4073 0 50 2Flakiness 0

Run details

Project cypress
Status Passed
Commit b6f4c25
Started May 19, 2021 8:10 PM
Ended May 19, 2021 8:20 PM
Duration 10:45 💡
OS Linux Debian - 10.8
Browser Electron 89

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member Author

What is this failure? This doesn't fail for me locally.

Screen Shot 2021-05-18 at 11 12 27 AM

Copy link

Seems to be in develop. Every PR is affected and it fails consistently. I was planning to look into it today.

@jennifer-shehane jennifer-shehane marked this pull request as ready for review May 18, 2021 19:01
@jennifer-shehane jennifer-shehane self-assigned this May 18, 2021
@jennifer-shehane jennifer-shehane merged commit da3bab6 into develop May 20, 2021
Copy link

cypress-bot bot commented May 24, 2021

Released in 7.4.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.4.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators May 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants