Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Migrate from listr to listr2 #16663

Merged
merged 10 commits into from Jun 1, 2021

Conversation

BradenM
Copy link
Contributor

@BradenM BradenM commented May 25, 2021

User facing changelog

  • Migrated from listr to listr2 for rxjs@^7 support.

Additional details

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?

@BradenM BradenM requested a review from a team as a code owner May 25, 2021 03:53
@BradenM BradenM requested review from chrisbreiding and kuceb and removed request for a team May 25, 2021 03:53
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 25, 2021

Thanks for taking the time to open a PR!

@CLAassistant
Copy link

CLAassistant commented May 25, 2021

CLA assistant check
All committers have signed the CLA.

@BradenM
Copy link
Contributor Author

BradenM commented May 25, 2021

From what I can tell, it looks like the failing tests are unrelated to my changes (given the current history on develop also).

Please let me know if I am wrong. Thanks.

@BradenM BradenM changed the title feat: Migrate from listr to list2 feat: Migrate from listr to listr2 May 25, 2021
Signed-off-by: Braden Mars <bradenmars@bradenmars.me>
Signed-off-by: Braden Mars <bradenmars@bradenmars.me>
Signed-off-by: Braden Mars <bradenmars@bradenmars.me>
Signed-off-by: Braden Mars <bradenmars@bradenmars.me>
Signed-off-by: Braden Mars <bradenmars@bradenmars.me>
@chrisbreiding chrisbreiding changed the title feat: Migrate from listr to listr2 fix: Migrate from listr to listr2 Jun 1, 2021
@chrisbreiding chrisbreiding merged commit 315d845 into cypress-io:develop Jun 1, 2021
@cypress-bot cypress-bot bot mentioned this pull request Jun 1, 2021
@SimenB
Copy link

SimenB commented Jun 8, 2021

This introduces a peer dependency warning:

➤ YN0000: cypress@npm:7.5.0 doesn't provide enquirer, breaking the following requirements:

➤ YN0000: listr2@npm:3.10.0 [db68a] → >= 2.3.0 < 3 ✘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot update rxjs@7
4 participants