-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix: make Cypress.ConfigOptions follow json Schema #17251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for taking the time to open a PR!
|
f16b4ce
to
e674838
Compare
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
BREAKING CHANGE: `Cypress.ConfigOptions`, `Cypress.ResolvedConfigOptions` and `Cypress.RuntimeConfigOptions` have been modified. If you are using them please check your types
e674838
to
b43c415
Compare
@elevatebart I don't see any test updates, can you clarify for me how this is a breaking change? |
@flotwig It is very unlikely though, since the types were wrong and nobody complained. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense. I see how this could be a breaking change even tho it's a typefix, I guess it's worth documenting in the CL as such too.
@elevatebart gonna merge this, but it would be extra sweet if you could add tests that help keep these types, |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
User facing changelog
The
Cypress.ConfigOptions
,Cypress.ResolvedConfigOptions
andCypress.RuntimeConfigOption
types have been updated so thatConfigOptions
match the json schemaAdditional details
This fixes inconsistencies in cypress externally exposed types