Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated record run instructions #17317

Merged
merged 20 commits into from Aug 12, 2021
Merged

feat: updated record run instructions #17317

merged 20 commits into from Aug 12, 2021

Conversation

panzarino
Copy link
Contributor

@panzarino panzarino commented Jul 14, 2021

Requires https://github.com/cypress-io/cypress-services/pull/3909 to be deployed with on link changes before this can be merged

User facing changelog

  • Updated record run instructions for some users

Additional details

We've added a new record run instructions screen for some users - using the same method of A/B testing as on the dashboard (by orgId) we hope to trial A/B tests in the TR. We'll be able to track whether or not this leads to an increased percentage of new orgs that end up recording runs to the dashboard. The new screen is similar to our current dashboard 0 state which showed a much better rate of recording runs along with helpful links in the cards at the bottom.

How has the user experience changed?

New (test group)

Screen Shot 2021-07-26 at 16 19 55

Old (control group)

Screen Shot 2021-07-26 at 16 20 13

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 14, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Jul 14, 2021



Test summary

4180 0 53 1Flakiness 3


Run details

Project cypress
Status Passed
Commit c04e764
Started Aug 12, 2021 7:33 PM
Ended Aug 12, 2021 7:43 PM
Duration 10:43 💡
OS Linux Debian - 10.9
Browser Firefox 89

View run in Cypress Dashboard ➡️


Flakiness

net_stubbing_spec.ts Flakiness
1 network stubbing > intercepting request > can intercept utf-8 request bodies without crashing
xhr_spec.js Flakiness
1 ... > causes errors caused by onreadystatechange callback function
2 src/cy/commands/xhr > abort > aborts xhrs currently in flight

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@panzarino panzarino marked this pull request as ready for review July 26, 2021 20:29
@panzarino panzarino requested a review from a team as a code owner July 26, 2021 20:29
@panzarino panzarino requested review from jennifer-shehane, kuceb and chrisbreiding and removed request for a team and kuceb July 26, 2021 20:29
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panzarino Can you resolve the conflicts and merge in develop. Will make this easier to test with the new project being fixed.

chrisbreiding
chrisbreiding previously approved these changes Jul 30, 2021
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panzarino When I set up a run to record, the record key doesn't populate on this screen. If I change tabs and come back to the Runs tab - it does populate the record key. I tried to fix some conflicts from develop around getting the record key so it's possible I may have introduced this myself.

Screen Shot 2021-07-30 at 11 08 12 AM

@panzarino
Copy link
Contributor Author

@jennifer-shehane I'm struggling to reproduce - do you have more specifics on when this occurs? From looking at the code I don't see any problems and I've tried a couple different workflows to try to get it to happen

@jennifer-shehane
Copy link
Member

@panzarino Sorry for the delay in replying. This is what I did:

  • Run yarn start in the staging environment
  • Login to Dashboard
  • Add completely new project to Cypress
  • Click on runs tab and connect to Dashboard
  • Create a 'new' project (not existing)
  • Click Setup Project

I've attached a gif below of the behavior.

@panzarino
Copy link
Contributor Author

@jennifer-shehane So I still wasn't able to reproduce by following those exact steps but I did realize that I had accidentally slightly changed some of the logic around when to load the record key. I've reverted back to the original working version that we had (before this PR) which should fix the issue you were experiencing (and also fixes a memory leak error).

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the record key populates now like it used it.

@panzarino panzarino merged commit 24774b6 into develop Aug 12, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 16, 2021

Released in 8.3.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v8.3.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants