Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency electron to v13 🌟 #17408

Merged
merged 11 commits into from
Aug 9, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 20, 2021

Redo of #17037

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
electron 12.0.0-beta.14 -> 13.1.7 age adoption passing confidence

Release Notes

electron/electron

v13.1.7

Compare Source

Release Notes for v13.1.7

Fixes

  • Fixed requestFullscreen inside webview does not make the element take fullscreen. #​29987 (Also in 12, 14)
  • Fixed a crash when calling the webContents.on('login') callback synchronously. #​30091 (Also in 12, 14)
  • Fixed a possible renderer crash when using fsPromises.readFile. #​29928
  • Fixed an issue where Electron would sometimes not honor the user-defined Downloads directory. #​29968 (Also in 12, 14)
  • Fixed an issue where the traffic lights would get double-drawn when exiting fullscreen and adding a BrowserView on macOS. #​30149 (Also in 14)
  • Fixed incorrect value of document.focus when opening multiple windows on macOS
    • fix key window status on mac when opening panels or using custom window switchers. #​29234 (Also in 12, 14)
  • Fixed systemPreferences.getSystemColor returning colors missing alpha values. #​30088 (Also in 14)

Other Changes

Documentation

v13.1.6

Compare Source

Release Notes for v13.1.6

Fixes

  • Fixed a potential crash when calling app.quit() on macOS. #​29961 (Also in 14)
  • Fixed an issue where self.module.paths wouldn't work in Workers. #​30013 (Also in 12, 14)
  • Fixed crash when clicking links with target=_blank from webview. #​29951 (Also in 12, 14)
  • Fixed memory leak when creating notification on macOS. #​30009 (Also in 14)
  • Fixed page title not being updated on child windows without navigation entries under nativeWindowOpen. #​29958 (Also in 12, 14)

Other Changes

v13.1.5

Compare Source

Release Notes for v13.1.5

Fixes

  • Fixed a hang when denying a window.open using setWindowOpenHandler when nativeWindowOpen: false. #​29882 (Also in 12, 14)
  • Fixed an issue where dropdown menus did not work in DevTools when contextIsolation was enabled. #​29885 (Also in 14)
  • Fixed an issue where request headers were cleared if the optional "requestHeaders" parameter was not included in the webRequest.onBeforeSendHeaders callback response object. #​29836 (Also in 12, 14)
  • Fixed an issue where the setAlwaysOnTop value would sometimes not be preserved for child windows on macOS. #​29956 (Also in 12, 14)
  • Fixed crashes on macOS when Geolocation was used. #​29912 (Also in 14)

Other Changes

v13.1.4

Compare Source

Release Notes for v13.1.4

Fixes

  • Fixed an issue with PDF loading on Windows, where metadata was not loading correctly and causing the PDF to load as a blank page. #​29830 (Also in 14)

v13.1.3

Compare Source

Release Notes for v13.1.3

Fixes

  • Fixed CORS preflight request always being cancelled when connecting via proxy requiring authentication for apps that had registered WebRequest listeners. #​29811 (Also in 12, 14)
  • Fixed select-bluetooth-device firing on Windows. #​29611 (Also in 12, 14)
  • Fixed warnAboutRemoteModuleWithRemoteContent for the new default value of enableRemoteModule. #​29691
  • Fixed a potential crash when setting vibrancy on macOS. #​29722 (Also in 14)
  • Fixed an issue where custom traffic lights could be covered by BrowserViews on macOS. #​29663 (Also in 14)
  • Fixed an issue where draggable regions sometimes did not work properly when DevTools is open. #​29734 (Also in 12, 14)
  • Fixed crashes in debug builds caused by microtasks policy mismatch. #​29808 (Also in 12, 14)
  • Fixed hover state not clear bug when BrowserWindow is not resizable. #​29800 (Also in 12, 14)
  • Fixed issue where the update permission prompt would cause 100% CPU spin while the prompt was open. #​29805 (Also in 14)
  • Fixed potential corruption of piped response data when using interceptHttpProtocol/registerHttpProtocol. #​29669 (Also in 11, 12, 14)
  • Fixed the color select eyedropper not working within DevTools. #​29760 (Also in 14)
  • Fixed the spelling of 'attachment' in 'Content-Disposition' header when using the webRequest module. #​29672 (Also in 12, 14)

Other Changes

  • Fixed a feature flag issue where spellchecker methods returned empty suggestion lists on Windows. #​29706 (Also in 14)
  • Updated Chromium to 91.0.4472.106. #​29700

Documentation

v13.1.2

Compare Source

Release Notes for v13.1.2

Fixes

  • Electron Fuses are now in a consistent order across platforms. #​29615 (Also in 14)
  • Fixd an issue where fs.promises.readFile would improperly error when passing a FileHandle to the path argument. #​29576 (Also in 14)
  • Fixed sending intermediate certificates with 'select-client-certificate' event callback. #​29569 (Also in 12, 14)
  • Fixed shifted character getting changed in menu accelerator. #​29482 (Also in 12, 14)

v13.1.1

Compare Source

Release Notes for v13.1.1

Fixes

  • Fixed crashes on latest gen Intel and Ryzen processors. #​29546
  • Fixed memory leak when requesting files in ASAR archive from renderer. #​29535 (Also in 14)

v13.1.0

Compare Source

Release Notes for v13.1.0

Features

Fixes

  • Fixed missing 'fetch' event in service workers for requests using a registered protocol. #​29446 (Also in 12, 14)
  • Fixed pressing Alt with mouse click results in toggling menu bar. #​29450 (Also in 12, 14)
  • Fixed pressing Alt+Shift and Alt+Ctrl toggling menu bar on KDE. #​29443 (Also in 12, 14)

Other Changes

Documentation

v13.0.1

Compare Source

Release Notes for v13.0.1

Fixes

  • Fixed SHA issue when creating a universal macOS build.

v13.0.0

Compare Source

Release Notes for v13.0.0

Stack Upgrades

Breaking Changes

  • Fixed so window.open() parameter frameName is no longer set as window title. #​27481
  • Changed session.setPermissionCheckHandler(handler) to allow for handler's first parameter, webContents to be null. #​19903

Features

Additions
  • Added process.contextId used by @electron/remote. #​28251
  • Added process.contextIsolated property that indicates whether the current renderer context has contextIsolation enabled. #​28252
  • Added process.uptime() to sandboxed renderers. #​26684
  • Added roundedCorners option for BrowserWindow. #​27572
  • Added missing fields to the parameters emitted as part of the context-menu event. #​26788
  • Added new session.storagePath API to get the path on disk for session-specific data. #​28866
  • Added support for passing DOM elements over the context bridge. #​26776
  • Added support for registering Manifest V3 extension service workers.
    • Added 'registration-completed' event to ServiceWorkers. #​27562
  • Added disposition, referrer and postBody to the details object passed to the window open handler registered with setWindowOpenHandler. #​29277
Improvements
  • Additional permission checks are now routed through session.setPermissionCheckHandler. These include Notification.permission, and permission.query. Please note that the webContents parameter to the check handler can now be null. #​19903
  • Allowed skipping process type transformation in win.SetVisibleOnAllWorkspaces on macOS. #​27200
  • Reverted WebFrameMain.executeJavaScriptInIsolatedWorld(). #​27926
  • Made trafficLightPosition option work for customButtonOnHover window. #​26789
  • The submitURL option for crashReporter.start is no longer a required argument when uploadToServer is false. #​28283
  • Improved performance of napi_threadsafe_function. #​29048 (Also in 12)
Removed/Deprecated

Fixes

  • Fixed hiddenInset titleBarStyle's abnormal fullscreen titlebar. Fix hiddenInset titleBarStyle not working with trafficLightPosition option. #​27489
  • Fixed a use-after-free bug during shutdown when using off-the-record sessions. #​26680
  • Fixed an issue where contextBridge might incorrectly try to serialize some WebAssembly objects. #​27518
  • Fixed behavior of 302/303/307 redirect responses in the protocol module. #​26297
  • Made BrowserWindow.setWindowButtonVisibility work for window with customButtonsOnHover titlebar style. #​27073
  • Fixed a rare crash on boot. #​29109
  • Fixed permissions issue that was preventing the PDF viewer from displaying. #​29252
  • Fixed the possibility for incorrect visual artifacts when using vibrancy and making frameless windows fullscreen on macOS. #​29099
  • Fixed using vibrancy with titleBarStyle together resulting in weird window shadow on macOS. #​29165
  • Restored cross-platform noop implementation of app.setAppUserModelId. #​28921
  • Security: backported fix for chromium:1196683. #​28637
Also in earlier versions....
  • Allow Node.js to manage microtasks queue by using explicit microtasks policy before calling uv_run(). #​28973 (Also in 11, 12)
  • Allow loading source maps from custom protocols and asar bundles. #​28615 (Also in 12)
  • Child windows with specified background colors or transpency now work as intended. #​28112 (Also in 12)
  • Colors returned from systemPreferences.getAccentColor(), getSystemColor and getColor are now correctly converted into the devices color space. Previously the color would have been subtly incorrect. #​28173 (Also in 11, 12)
  • Fixed ECDH.setPrivateKey() not updating the key. #​27688 (Also in 12)
  • Fixed <webview> focus / blur events not working with contextIsolation enabled. #​29025 (Also in 10, 11, 12)
  • Fixed desktopCapturer.getSources() promise result sometimes never resolving. #​28280 (Also in 10, 11, 12)
  • Fixed postData parameter missing from new-window event. #​28542 (Also in 12)
  • Fixed webFrame spell checker APIs crashing when called in sandboxed renderer. #​29087 (Also in 12)
  • Fixed a bug where, when a JumpList task description exceeded 260 characters, the JumpList was empty, despite valid entries. #​28526 (Also in 11, 12)
  • Fixed a crash when calling shell.trashItem() from the renderer process. #​28788 (Also in 12)
  • Fixed a crash when loading pepper plugins. #​28372 (Also in 12)
  • Fixed a network process crash that could happen when using setCertificateVerifyProc with many concurrent verification requests. #​28433 (Also in 11, 12)
  • Fixed a potential crash when resetting BrowserViews. #​27786 (Also in 12)
  • Fixed a rare crash on Windows that could occur when emitting certain Tray events. #​26668 (Also in 12)
  • Fixed an issue where BrowserViews could have mismatched draggable regions to their bounds. #​27952 (Also in 10, 11, 12)
  • Fixed an issue where illegal access error could be thrown when nodeIntegrationInSubFrames is enabled. #​29170 (Also in 12)
  • Fixed an issue where select-serial-port callback crashes when called with an invalid serial port ID. #​28619 (Also in 12)
  • Fixed an issue where win.capturePage() never called back after calling hide() for a hidden window on some platforms. #​28076 (Also in 11, 12)
  • Fixed an issue where window.print() did not work properly when printing a pdf from the pdf plugin. #​28351 (Also in 12)
  • Fixed an issue where drag regions on macOS would be offset incorrectly when no drag regions were set,. #​29017 (Also in 11, 12)
  • Fixed an issue where errors thrown in functions passed over the contextBridge could be displayed incorrectly. #​28446 (Also in 12)
  • Fixed an issue where extensions without a background page might not have file access. #​29171 (Also in 12)
  • Fixed an issue where libuv might hang with multiple subframes when nodeIntegrationInSubframes is enabled. #​27582 (Also in 10, 11, 12)
  • Fixed an issue where multiple calls to window.setFullScreen could cause problems. #​28763 (Also in 11, 12)
  • Fixed an issue where some Node.js modules would hang on page reload on Windows. #​28335 (Also in 11, 12)
  • Fixed an issue where some dialogs would stop working on macOS if window.hide() was called while they were open. #​28694 (Also in 11, 12)
  • Fixed an issue where the drag regions in BrowserViews on macOS could be off in their y-axis. #​28298 (Also in 10, 11, 12)
  • Fixed an issue where the thumbar disappeared after win.hide() on Windows. #​28390 (Also in 10, 11, 12)
  • Fixed an issue where the void function Menu.setApplicationMenu would return a value on some platforms. #​29129 (Also in 12)
  • Fixed an issue where the window couldn't be closed if a user tried to quit with a message box showing. #​28988 (Also in 12)
  • Fixed an issue where windows in simpleFullscreen mode were not properly resizing when display metrics changed. #​28216 (Also in 11, 12)
  • Fixed an out-of-bounds access in WebContents.sendInputEvent. #​27827 (Also in 10, 11, 12)
  • Fixed background color not being applied for child windows created by native window.open path. #​27593 (Also in 10, 11, 12)
  • Fixed bug where TouchBarPopover and TouchBarGroup were no longer rendering. #​27901 (Also in 11, 12)
  • Fixed context menus not being positioned correctly when near the edge of the screen. #​28276 (Also in 11, 12)
  • Fixed corner radius for vibrancy view in macOS 11. #​28679 (Also in 11, 12)
  • Fixed crash when an exception occurs within the event emitter. #​29106
  • Fixed crash when calling getBackgroundColor on a transparent window with no assigned background color. #​28187 (Also in 11, 12)
  • Fixed failing to request file:// resources when web security is disabled. #​28557 (Also in 11, 12)
  • Fixed intensive I/O from asar files causing ERR_FILE_NOT_FOUND after a while. #​28203 (Also in 11, 12)
  • Fixed issue where window.open() would not return an object with a location.href setter when contextIsolation is enabled and nativeWindowOpen is disabled. #​27899 (Also in 12)
  • Fixed navigator.bluetooth.requestDevice. #​27902 (Also in 11, 12)
  • Fixed rare crash when initializing the internal PDF extension. #​28453 (Also in 12)
  • Fixed service worker not working with custom protocol. #​28354 (Also in 11, 12)
  • Fixed the handler set with setWindowOpenHandler not being invoked when a link was middle-clicked or shift-clicked. #​28536 (Also in 12)
  • Fixed the window-all-closed event being emitted while the last BrowserWindow was still in the process of being closed. #​28914 (Also in 11, 12)
  • Fixed warning when worldSafeExecuteJavaScript is disabled. #​27928 (Also in 10, 11, 12)
  • No longer set backgroundColor in default-app when opening custom files / URLs. #​28842 (Also in 10, 11, 12)
  • Support wasm-eval csp behind WebAssemblyCSP flag. #​28569 (Also in 11, 12)
  • Transparent windows cannot be maximized using the Windows system menu or by double clicking the title bar. #​28527 (Also in 12)
  • URLS passed to shell.openExternal on windows are now correctly URI encoded. This was already occurring on macOS and Linux. #​28342 (Also in 10, 11, 12)
  • Fixed native module compilation with AsyncCleanupHooks on windows. #​28110 (Also in 11, 12)
  • Fixed will-resize and will-move events not scaling the emitted newBounds rectangle to the appropriate Windows display scale factor. #​29227 (Also in 11, 12)
  • Fixed drag and drop not working correctly for some x11 window managers. #​29233 (Also in 11, 12)

Other Changes

  • Non-functional change; updates repository's issue template file. #​27825
  • Updated community discussions link in default Electron menu. #​28459 (Also in 12)

Documentation

End of Support for 10.x.y

Electron 10.x.y has reached end-of-support as per the project's support policy. Developers and applications are encouraged to upgrade to a newer version of Electron.

v12.0.15

Compare Source

Release Notes for v12.0.15
Fixes
  • Fixed a crash when calling the webContents.on('login') callback synchronously. #​30092 (Also in 13, 14)
  • Fixed a potential crash when calling app.quit() on macOS. #​30138 (Also in 13, 14)
  • Fixed key window status on mac when opening panels or using custom window switchers. #​30067 (Also in 14)
  • Fixed pressing ESC not exiting fullscreen from webview. #​30137 (Also in 14)
Other Changes
Documentation

v12.0.14

Compare Source

Release Notes for v12.0.14

Fixes

  • Fixed requestFullscreen inside webview does not make the element take fullscreen. #​29988 (Also in 13, 14)
  • Fixed a possible renderer crash when using fsPromises.readFile. #​29929
  • Fixed an issue where Electron would sometimes not honor the user-defined Downloads directory. #​29966 (Also in 13, 14)
  • Fixed an issue where self.module.paths wouldn't work in Workers. #​30012 (Also in 13, 14)
  • Fixed an issue where the setAlwaysOnTop value would sometimes not be preserved for child windows on macOS. #​29957 (Also in 13, 14)
  • Fixed crash when clicking links with target=_blank from webview. #​29950 (Also in 13, 14)
  • Fixed memory leak when creating notification on macOS. #​30007 (Also in 13, 14)
  • Fixed page title not being updated on child windows without navigation entries under nativeWindowOpen. #​29960 (Also in 13, 14)

Other Changes

v12.0.13

Compare Source

Release Notes for v12.0.13

Fixes

  • Fixed a hang when denying a window.open using setWindowOpenHandler when nativeWindowOpen: false. #​29881 (Also in 13, 14)
  • Fixed an issue where request headers were cleared if the optional "requestHeaders" parameter was not included in the webRequest.onBeforeSendHeaders callback response object. #​29834 (Also in 13, 14)

Other Changes

v12.0.12

Compare Source

Release Notes for v12.0.12

Fixes

  • Fixd an issue where fs.promises.readFile would improperly error when passing a FileHandle to the path argument. #​29575 (Also in 13, 14)
  • Fixed CORS preflight request always being cancelled when connecting via proxy requiring authentication for apps that had registered WebRequest listeners. #​29810 (Also in 13, 14)
  • Fixed select-bluetooth-device firing on Windows. #​29612 (Also in 13, 14)
  • Fixed an incorrect warning about enableRemoteModule being issued when the option was undefined (and thus defaulting to false). #​29701
  • Fixed an issue where draggable regions sometimes did not work properly when DevTools is open. #​29733 (Also in 13, 14)
  • Fixed crashes in debug builds caused by microtasks policy mismatch. #​29807 (Also in 13, 14)
  • Fixed hover state not clear bug when BrowserWindow is not resizable. #​29799 (Also in 13, 14)
  • Fixed potential corruption of piped response data when using interceptHttpProtocol/registerHttpProtocol. #​29668 (Also in 11, 13, 14)
  • Fixed the spelling of 'attachment' in 'Content-Disposition' header when using the webRequest module. #​29671 (Also in 13, 14)
  • Security: backported fix for CVE-2021-30551. #​29779

Other Changes

Documentation

v12.0.11

Compare Source

Release Notes for v12.0.11

Fixes

  • Fixed memory leak when requesting files in ASAR archive from renderer. #​29548 (Also in 13, 14)
  • Fixed sending intermediate certificates with 'select-client-certificate' event callback. #​29568 (Also in 13, 14)
  • Fixed shifted character getting changed in menu accelerator. #​29483 (Also in 13, 14)

v12.0.10

Compare Source

Release Notes for v12.0.10
Fixes
  • Fixed drag and drop not working correctly for some x11 window managers. #​29272 (Also in 11)
  • Fixed missing 'fetch' event in service workers for requests using a registered protocol. #​29447 (Also in 13, 14)
  • Fixed pressing Alt with mouse click results in toggling menu bar. #​29451 (Also in 13, 14)
  • Fixed pressing Alt+Shift and Alt+Ctrl toggling menu bar on KDE. #​29445 (Also in 13, 14)
Other Changes
Documentation

v12.0.9

Compare Source

Release Notes for v12.0.9

Fixes

  • Fixed will-resize and will-move events not scaling the emitted newBounds rectangle to the appropriate Windows display scale factor. #​29226 (Also in 11, 13)
  • Fixed incorrect value of document.focus when opening multiple windows on macOS. #​29235

v12.0.8

Compare Source

Release Notes for v12.0.8
Fixes
  • Fixed webFrame spell checker APIs crashing when called in sandboxed renderer. #​29086 (Also in 13)
  • Fixed an issue where illegal access error could be thrown when nodeIntegrationInSubFrames is enabled. #​29169 (Also in 13)
  • Fixed an issue where extensions without a background page might not have file access. #​29172 (Also in 13)
  • Fixed an issue where the void function Menu.setApplicationMenu would return a value on some platforms. #​29128 (Also in 13)
  • Fixed corner radius for vibrancy view in macOS 11. #​29071 (Also in 11, 13)
Documentation

v12.0.7

Compare Source

Release Notes for v12.0.7

Fixes

  • Allow Node.js to manage microtasks queue by using explicit microtasks policy before calling uv_run(). #​28972 (Also in 11, 13)
  • Fixed <webview> focus / blur events not working with contextIsolation enabled. #​29024 (Also in 10, 11, 13)
  • Fixed an issue where drag regions on macOS would be offset incorrectly when no drag regions were set,. #​29019 (Also in 11, 13)
  • Fixed an issue where the window couldn't be closed if a user tried to quit with a message box showing. #​28989 (Also in 13)

Other Changes

  • Improved performance of napi_threadsafe_function. #​29047 (Also in 13)

v12.0.6

Compare Source

Release Notes for v12.0.6

Fixes


Configuration

πŸ“… Schedule: "before 3am on the first day of the month" in timezone America/New_York.

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

β™» Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

πŸ”• Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner July 20, 2021 15:04
@renovate renovate bot requested review from flotwig and chrisbreiding and removed request for a team July 20, 2021 15:04
@renovate renovate bot added renovate Triggered by renovatebot type: dependencies labels Jul 20, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 20, 2021

See the guidelines for reviewing dependency updates for info on how to review dependency update PRs.

@jennifer-shehane jennifer-shehane removed the request for review from chrisbreiding July 20, 2021 15:10
@jennifer-shehane
Copy link
Member

Going to run some experiments to see if this change, which updates Electron to Chromium 91 will introduce performance issues for users running on low resourced machines.

@cypress
Copy link

cypress bot commented Jul 30, 2021



Test summary

18192 β€’ 0 β€’ 214 β€’ 7 β€’ Flakiness 1


Run details

Project cypress
Status Passed
Commit e2d4a68
Started Aug 9, 2021 9:54 PM
Ended Aug 9, 2021 10:05 PM
Duration 11:48 πŸ’‘
OS Linux Debian - 10.9
Browser Multiple

View run in Cypress Dashboard ➑️


Flakiness

cypress/integration/commands/net_stubbing_spec.ts 1Β Flakiness
1 network stubbing > intercepting request > can intercept utf-8 request bodies without crashing

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@jennifer-shehane
Copy link
Member

Running on Chrome 91 or Electron 31 results in 24% slower runtime than Chrome 88 runs (due to increased frames being written since Chrome 89). Pausing on merging this in until we come to a conclusion on how to handle this update.

@flotwig flotwig changed the title chore(deps): update dependency electron to v13 🌟 fix(deps): update dependency electron to v13 🌟 Aug 9, 2021
@flotwig flotwig merged commit 9df2543 into develop Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
renovate Triggered by renovatebot type: dependencies
Projects
None yet
3 participants