-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow cypress.config.js to be a default config file #18221
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
I think I forgot to add the conflict error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
When using
cypress.config.js
and setting up a project, the projectId is not being written to the thecypress.config.js
file, it's instead creating a newcypress.json
file and writing the projectId into that file. This means if they directly go to run the record run command - they'll get an error about 2 config files. This critical path has to be fixed.The same bug occurs if you pass a custom
--config-file
, it creates a newcypress.json
and adds the projectId there instead. -
If this is a JS file, the preview should show as
module.exports = { projectId: ...}
-
Is the nodeVersion being used to read in their
cypress.config.js
also? Does that need to be noted here? -
The percy snapshots are not working, not showing the correct config file in the desktop-gui screenshots.
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you go to copy to clipboard the projectId preview when it's a JS file, including the module.exports
, it only copies the JSON portion. This experience is odd. I'd expect it to copy the text that it is showing me.
A couple minor text fixes.
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
@jennifer-shehane copy to clipboard has been fixed in 22cfcc9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed the copy to clipboard is now working.
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
User facing changelog
Now one can use cypress.config.js as a default config file instead of cypress.json
Additional details
When this file is present, no cypress.json will be created
If both files (json and js) are present cypress should error
Desktop gui was adapted as well like so
PR Tasks