Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set projectId in a custom config file #18240

merged 10 commits into from Sep 27, 2021


Copy link

@elevatebart elevatebart commented Sep 24, 2021

User facing changelog

When using a custom config file and setting up its connection to the dashboard, Cypress now writes the projectId in the custom config file instead of cypress.json.

To test

Create a project with a custom.json file as the configuration

yarn install
yarn start --project=/path/to/the/project --config-file=custom.json

Then open the runs tab

Finally, connect the current project with the Cypress cloud

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?

Copy link

cypress-bot bot commented Sep 24, 2021

Thanks for taking the time to open a PR!

Copy link

cypress bot commented Sep 24, 2021

Test summary

18502 0 214 7Flakiness 2

Run details

Project cypress
Status Passed
Commit f54deca
Started Sep 27, 2021 1:53 PM
Ended Sep 27, 2021 2:03 PM
Duration 10:27 💡
OS Linux Debian - 10.9
Browser Multiple

View run in Cypress Dashboard ➡️


cypress/proxy-logging-spec.ts Flakiness
1 ... > works with forceNetworkError
e2e/redirects_spec.js Flakiness
1 redirection > meta > binds to the new page after a timeout

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@elevatebart elevatebart changed the title fix: set projectId in the custom config file fix: set projectId in a custom config file Sep 26, 2021
@elevatebart elevatebart marked this pull request as ready for review September 26, 2021 21:33
@elevatebart elevatebart requested a review from a team as a code owner September 26, 2021 21:33
@elevatebart elevatebart requested review from chrisbreiding and removed request for a team September 26, 2021 21:33
Copy link

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and thanks for the writeup on how to test the feature manually. I manually tested and it looks good. Tests updated as well.

@jennifer-shehane jennifer-shehane merged commit c6758dc into develop Sep 27, 2021
63 checks passed
@elevatebart elevatebart deleted the fix/setup-project-id-in-custom-file branch March 24, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

cypress open - new projectId creation not respecting --config-file
2 participants