Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin ua-parser-js to non compromised version #18611

Merged
merged 1 commit into from
Oct 23, 2021

Conversation

ImCesar
Copy link
Contributor

@ImCesar ImCesar commented Oct 22, 2021

The ua-parser-js package was compromised and later versions install malware. Pin ua-parser-js to the version we use until things clear up

faisalman/ua-parser-js#536

User facing changelog

Pinned ua-parser-js package to non compromised version

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 22, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Oct 22, 2021



Test summary

18560 0 214 7Flakiness 3


Run details

Project cypress
Status Passed
Commit 97cb16a
Started Oct 22, 2021 11:14 PM
Ended Oct 22, 2021 11:30 PM
Duration 15:44 💡
OS Linux Debian - 10.9
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

commands/net_stubbing_spec.ts Flakiness
1 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
cypress/proxy-logging-spec.ts Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code
settings_spec.js Flakiness
1 Settings > file preference panel > loads preferred editor and available editors

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@JessicaSachs JessicaSachs merged commit dcefd77 into develop Oct 23, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 25, 2021

Released in 8.7.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v8.7.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Oct 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants