fix: Allow 'this' to be used in overridden commands#18899
Merged
Conversation
Contributor
|
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Failures
Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||||||||||
emilyrohrbough
approved these changes
Nov 15, 2021
tgriesser
approved these changes
Nov 16, 2021
chrisbreiding
approved these changes
Nov 16, 2021
Contributor
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thiscontext can't be overwritten #18892User facing changelog
Cypress commands that rely on
thiscan now be overridden cleanly,Additional details
Previously, there was no clean way to invoke an overridden command that, for example, read the test title:
I don't believe this requires any change in the documentation - it's a fairly niche limitation for command authors. This just makes our API work as you would expect if familiar with JS, instead of having an unexpected limitation. There was no particularly good reason for this limitation, and removing it is easy.
PR Tasks