Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use supportFile by testingType #19364

Merged
merged 37 commits into from
Jan 5, 2022

Conversation

estrada9166
Copy link
Member

@estrada9166 estrada9166 commented Dec 14, 2021

User facing changelog

Additional details

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 14, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Dec 14, 2021



Test summary

18560 0 218 0Flakiness 5


Run details

Project cypress
Status Passed
Commit ce5e0af
Started Jan 5, 2022 5:18 PM
Ended Jan 5, 2022 5:30 PM
Duration 11:54 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

commands/net_stubbing_spec.ts Flakiness
1 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
2 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
cypress/proxy-logging-spec.ts Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code
2 ... > works with forceNetworkError
3 Proxy Logging > request logging > xhr log has response body/status code

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@estrada9166 estrada9166 closed this Jan 3, 2022
@estrada9166 estrada9166 reopened this Jan 3, 2022
@estrada9166 estrada9166 marked this pull request as ready for review January 3, 2022 23:56
lmiller1990
lmiller1990 previously approved these changes Jan 4, 2022
Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing, I went through this PR as carefully as I could, looks good!

.eslintignore Outdated
@@ -22,7 +22,8 @@ system-tests/projects/**/static/*
system-tests/projects/**/*.jsx
system-tests/projects/**/fail.js
system-tests/lib/scaffold/plugins/index.js
system-tests/lib/scaffold/support/index.js
system-tests/lib/scaffold/support/e2e.js
system-tests/lib/scaffold/support/commaponent.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be spelled commaponent.js?

@lmiller1990
Copy link
Contributor

I tried it out, seems great! I'll use your new error handling stuff for the specPattern changes once this lands.

image

lmiller1990
lmiller1990 previously approved these changes Jan 5, 2022
const E2E_SCAFFOLD_BODY = (opts: E2eScaffoldOpts) => {
return `
e2e: {
supportFile: ${opts.lang === 'ts' ? '\'cypress/support/e2e.ts\'' : '\'cypress/support/e2e.js\''},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
supportFile: ${opts.lang === 'ts' ? '\'cypress/support/e2e.ts\'' : '\'cypress/support/e2e.js\''},
supportFile: '\'cypress/support/e2e.${opts.lang}\'',

tgriesser
tgriesser previously approved these changes Jan 5, 2022
tgriesser
tgriesser previously approved these changes Jan 5, 2022
@estrada9166 estrada9166 merged commit 0366d4f into 10.0-release Jan 5, 2022
@estrada9166 estrada9166 deleted the alejandro/feat/supportFile-by-testing-type branch January 5, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants