fix: click event is fired correctly when focus has changed

[sainthkh]

• Next step of chore: move cy.type() event tests to its own file. #20191
• Final step of type('{enter}') does not fire click event #19541
• Related with this comment

User facing changelog

Click events are fired correctly when focus is changed on event handlers.

Additional details

• Why was this change necessary? => When the focus is changed on event handlers, the newly focused object got the click event. This PR simulates this behavior.
• What is affected by this change? => N/A

Any implementation details to explain?

Click event emitting is a bit different between enter and space.

• Click event is fired on the newly-focused element when enter is pressed.
• Click event is not fired on any element when space is pressed.

Before this PR, Cypress behavior is the opposite (not firing on enter and firing on space). This PR fixes this issue.

How has the user experience changed?

Before: Click event is not sent on enter and sent on space. => Buggy behavior.
After: Click event is sent on enter and not sent on space. => Correct behavior.

PR Tasks

• Have tests been added/updated?
• Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
• [na] Has a PR for user-facing changes been opened in cypress-documentation?
• [na] Have API changes been updated in the type definitions?
• [na] Have new configuration options been added to the cypress.schema.json?

[cypress-bot]

Thanks for taking the time to open a PR!

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
• Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

[BlueWinds]

This is a fascinating and subtle interaction. The event logging style of tests make it really easy to understand exactly what's going on, since you can play with them directly in the AUT iframe.

[BlueWinds]

Because you only push events onto this array when type === keydown, there's no need to check the type again later. So this could be simplified to

 if (event.type === 'keydown') {
  keydownEventTargets.push(event.target);
}

// then below...

// When a space key is pressed on another element, the click event should not be fired.
keydownEventTargets.includes(target)

removing the need to define keydownFiredOnThisElement at all.

[sainthkh]

At first, I logged all events. But I realized that it could slow down Cypress a lot. So, the code became this way.

Your code is much simpler.

Thanks!

[cypress-bot]

Released in 9.5.2.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v9.5.2, please open a new issue.