fix: remove baseUrl from root-level types for supported fields #20589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ FlakinessThis comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
lmiller1990
reviewed
Mar 15, 2022
| Cypress.config({ baseUrl: '.', }) // $ExpectType void | ||
| Cypress.config({ e2e: { baseUrl: '.' }}) // $ExpectType void | ||
| Cypress.config({ e2e: { baseUrl: null }}) // $ExpectType void | ||
| Cypress.config({ e2e: { baseUrl: '.', }}) // $ExpectType void |
There was a problem hiding this comment.
do we need one of these tests asserting component.baseUrl is not allowed? (I am not sure if these inline, string-based assertions support that)
lmiller1990
previously approved these changes
Mar 15, 2022
lmiller1990
approved these changes
Mar 15, 2022
emilyrohrbough
changed the title
emilyrohrbough
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Update types with supported fields on the root level and with each testing type
Additional details
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?