fix(session): error thrown by unset cookies when printing session details to dev tools console #20946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilyrohrbough
requested review from
jennifer-shehane
and removed request for
a team
|
Thanks for taking the time to open a PR!
|
emilyrohrbough
changed the title
mjhenkes
approved these changes
Apr 6, 2022
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
mschile
approved these changes
Apr 6, 2022
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue observed when cookies have not be set within a session and the user clicks the command log to view additional details. Discovered this issue when following along with the cy.session documentation examples in the docs pages.
Error details
Observe issue & fix from updated tests:
Screen.Recording.2022-04-06.at.2.55.31.PM.mov
User facing changelog
Fixed an edge-case error observed in
cy.sessionwhere an error is thrown when no cookies have been set for the session and the user clicks the session command log to view additional details in the dev tools console.How has the user experience changed?
No error when clicking the session log.
PR Tas
cypress-documentation?type definitions?cypress.schema.json?