Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): show additional mitigation steps for max path length error #21047

Merged
merged 4 commits into from Apr 14, 2022

Conversation

flotwig
Copy link
Member

@flotwig flotwig commented Apr 12, 2022

User facing changelog

  • Improved the error message Cypress throws when max file length is exceeded on Windows platforms and added mitigation steps.
  • This is pretty easy to check - the syscall is always realpath and the code is always ENOENT when this throws.
  • Could have done an even more excessive check like in 155742b but I think this is not necessary.
  • Also opened a docs PR for the mitigation steps: cypress-io/cypress-documentation#4437
  • And an onlink PR: cypress-io/cypress-services#4441

Additional details

How has the user experience changed?

PR Tasks

@cypress-bot
Copy link

@cypress-bot cypress-bot bot commented Apr 12, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

@cypress cypress bot commented Apr 12, 2022



Test summary

19391 0 218 0Flakiness 2


Run details

Project cypress
Status Passed
Commit 999c805
Started Apr 13, 2022 6:04 PM
Ended Apr 13, 2022 6:16 PM
Duration 11:41 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

commands/waiting_spec.js Flakiness
1 ... > errors > throws when waiting for 2nd response to route
cypress/proxy-logging_spec.ts Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged second

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig flotwig changed the title fix(cli): show additional mitigation steps if max file length is detected during unzip fix(cli): show additional mitigation steps for max path length error Apr 12, 2022
@flotwig flotwig marked this pull request as ready for review Apr 12, 2022
@flotwig flotwig requested a review from as a code owner Apr 12, 2022
@flotwig flotwig requested review from jennifer-shehane (assigned from cypress-io/end-to-end), marktnoonan and and removed request for and jennifer-shehane Apr 12, 2022
@jennifer-shehane jennifer-shehane removed the request for review from Apr 12, 2022
cli/__snapshots__/unzip_spec.js Outdated Show resolved Hide resolved
@flotwig flotwig requested a review from cowboy Apr 12, 2022
@tbiethman tbiethman self-requested a review Apr 13, 2022
Copy link
Contributor

@tbiethman tbiethman left a comment

New error looks good and tests are solid 👍

Copy link
Contributor

@marktnoonan marktnoonan left a comment

Changes look good, really happy to have this guidance for users about what's otherwise a really unintuitive error.

@flotwig flotwig merged commit 546ed16 into develop Apr 14, 2022
64 of 65 checks passed
@flotwig flotwig deleted the unify-1449-enhanced-unzip-error branch Apr 14, 2022
tgriesser added a commit that referenced this issue Apr 20, 2022
…e-config

* 10.0-release:
  fix: make error on integration folder point to e2e (#20853)
  fix(unify): Update Cypress Dashboard Service Link in Login Modal (#21084)
  chore: fix windows node_modules install step (#21098)
  fix: webpack integration tests for app w webpack-dev-server-fresh (#21093)
  fix: move non spec files on migration (#21054)
  Bumping electron version in root
  chore(deps): Bumping electron dependency to 15.5.1 (#21072)
  fix: resolves correctly specPattern (#21057)
  feat: replace reconfigure button on settings page with link to config doc (#21077)
  feat(launchpad): update CT setup and config scaffolding (#20893)
  fix: cy.type('{enter}') on <input> elements submits the form correctly after Firefox 98. (#21042)
  chore: making the npm deps for vue, react, and vue2 use 0.0.0-dev (#21081)
  fix(cli): show additional mitigation steps for max path length error (#21047)
  fix: Plugin error when sending on disconnected IPC channel (#21011)
  chore: add internal types for cy.session command (#21028)
  chore: Update Chrome (stable) to 100.0.4896.88 (#21043)
@cypress-bot
Copy link

@cypress-bot cypress-bot bot commented Apr 25, 2022

Released in 9.6.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v9.6.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants