fix: update not supported plugins errors #21169
Conversation
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
estrada9166
requested review from
jennifer-shehane,
chrisbreiding and
lmiller1990
and removed request for
a team and
jennifer-shehane
There was a problem hiding this comment.
I think it would be better if the error message were formatted like:
Cypress detected that the current version of @cypress/code-coverage is not supported. Update it to the latest version.
The following error was caught:
> glob pattern string required
Because this error occurred during a after all hook we are skipping all of the remaining tests.
| @@ -987,6 +987,8 @@ const _runnerListeners = (_runner, Cypress, _emissions, getTestById, getTest, se | |||
| hookName = getHookName(runnable) | |||
| const test = getTest() || getTestFromHookOrFindTest(runnable) | |||
|
|
|||
| const unsupportedPlugin = runnable.invocationDetails && runnable.invocationDetails.originalFile && runnable.err && runnable.err.message ? $errUtils.getUnsupportedPlugin(runnable.invocationDetails.originalFile, runnable.err.message) : null | |||
There was a problem hiding this comment.
Maybe pass the runnable to $errUtils.getUnsupportedPlugin and let it take care of this logic and return null if these properties aren't available?
|
Nice @estrada9166, for completion sake (and it it's not too difficult) can you add a screenshot of how the error looks? I think it'll be useful for historical context, if we ever look back, as well as for the final review and ✔️ 🙏 |
|
Alright got the double ✅ , let's ship it. |
lmiller1990
deleted the
alejandro/fix/update-not-supported-plugins-error
branch
User facing changelog
Some plugins are not supported in v-10, is for this reason that the error that is being thrown has been updated depending if we are able to identify that the reason is the invalid plugin
Before
After
Additional details
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?