Skip to content

fix: Files with special characters aren't handled properly in GitDataSource on Windows #21436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 13, 2022

Conversation

MuazOthman
Copy link
Contributor

User facing changelog

Fixed an issue where files with special characters aren't handled properly in GitDataSource on Windows

Additional details

How has the user experience changed?

PR Tasks

  • [na] Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

@MuazOthman MuazOthman requested a review from tgriesser as a code owner May 11, 2022 15:24
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 11, 2022

Thanks for taking the time to open a PR!

@BlueWinds BlueWinds requested review from BlueWinds and tbiethman May 11, 2022 15:41
Copy link
Contributor

@tbiethman tbiethman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good, but it'd be helpful to add your PR branch to the circle config and confirm a clean windows build (for this spec at least) prior to to merging.

Example: https://github.com/cypress-io/cypress/blob/10.0-release/circle.yml#L60

@cypress
Copy link

cypress bot commented May 11, 2022



Test summary

9288 1 109 0Flakiness 9


Run details

Project cypress
Status Failed
Commit 6a7e091
Started May 13, 2022 2:38 PM
Ended May 13, 2022 3:01 PM
Duration 22:27 💡
OS Linux Debian - 10.10
Browser Electron 94

View run in Cypress Dashboard ➡️


Failures

cypress/e2e/cypress/proxy-logging.cy.ts Failed
1 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged first

Flakiness

cypress/proxy-logging.cy.ts Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged first
commands/navigation.cy.js Flakiness
1 src/cy/commands/navigation > #visit > window immediately resolves and doesn't reload when visiting the same URL with hashes
e2e/origin/commands/screenshot.cy.ts Flakiness
1 cy.origin screenshot > #consoleProps > .screenshot()
e2e/origin/commands/waiting.cy.ts Flakiness
1 cy.origin waiting > #consoleProps > .wait()
e2e/origin/commands/connectors.cy.ts Flakiness
1 cy.origin connectors > #consoleProps > .its()
This comment includes only the first 5 flaky tests. See all 9 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@MuazOthman MuazOthman merged commit a86514d into 10.0-release May 13, 2022
@MuazOthman MuazOthman deleted the muaz/UNIFY-1741-fix-git-cmd-win branch May 13, 2022 14:58
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 1, 2022

Released in 10.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jun 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants