-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix: Files with special characters aren't handled properly in GitDataSource on Windows #21436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…Source on Windows
Thanks for taking the time to open a PR!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix looks good, but it'd be helpful to add your PR branch to the circle config and confirm a clean windows build (for this spec at least) prior to to merging.
Example: https://github.com/cypress-io/cypress/blob/10.0-release/circle.yml#L60
Test summaryRun details
View run in Cypress Dashboard ➡️ Failures
Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
User facing changelog
Fixed an issue where files with special characters aren't handled properly in GitDataSource on Windows
Additional details
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?