-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix: avoid timer size changing as it counts up #22846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for taking the time to open a PR!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a fan
approved by design ✅ (they love it!) TIL about |
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
User facing changelog
N/A - very minor style tweak
Additional details
Adds
font-variant-numermic: tabular nums
to stop the timer shifting around depending on the different character widths of each number. Makes non-fixed-width numbers behave like fixed-width. This is the tiniest thing but it catches my eye every now and then and bugs me.Steps to test
Run any spec and watch the timer.
How has the user experience changed?
Before:
before.mov
After:
after.mov
PR Tasks
cypress-documentation
?type definitions
?