Skip to content

fix: avoid timer size changing as it counts up #22846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 19, 2022

Conversation

marktnoonan
Copy link
Contributor

  • Closes n/a

User facing changelog

N/A - very minor style tweak

Additional details

Adds font-variant-numermic: tabular nums to stop the timer shifting around depending on the different character widths of each number. Makes non-fixed-width numbers behave like fixed-width. This is the tiniest thing but it catches my eye every now and then and bugs me.

Steps to test

Run any spec and watch the timer.

How has the user experience changed?

Before:

before.mov

After:

after.mov

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@marktnoonan marktnoonan requested a review from a team as a code owner July 19, 2022 16:02
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 19, 2022

Thanks for taking the time to open a PR!

@marktnoonan marktnoonan requested review from ryanthemanuel and mapsandapps and removed request for a team July 19, 2022 16:02
Copy link
Contributor

@ZachJW34 ZachJW34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a fan

@mapsandapps
Copy link
Contributor

approved by design ✅ (they love it!)

TIL about font-variant-numermic: tabular-nums. thanks!

@cypress
Copy link

cypress bot commented Jul 19, 2022



Test summary

37729 0 456 0Flakiness 8


Run details

Project cypress
Status Passed
Commit 96e392c
Started Jul 19, 2022 6:31 PM
Ended Jul 19, 2022 6:48 PM
Duration 17:28 💡
OS Linux Debian - 10.11
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

actions/click.cy.js Flakiness
1 ... > scroll-behavior > can scroll to and click elements in html with scroll-behavior: smooth
net_stubbing.cy.ts Flakiness
1 network stubbing > waiting and aliasing > yields the expected interception when two requests are raced
xhr.cy.js Flakiness
1 ... > logs request + response headers
2 ... > logs Method, Status, URL, and XHR
3 ... > logs response
This comment includes only the first 5 flaky tests. See all 8 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@marktnoonan marktnoonan merged commit 2def224 into develop Jul 19, 2022
@marktnoonan marktnoonan deleted the marktnoonan/reporter-timer-font-variant branch July 19, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants