Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add MaybeSimulateSecHeaders code to prevent 403 issues with google #23720

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

AtofStryker
Copy link
Contributor

@AtofStryker AtofStryker commented Sep 8, 2022

User facing changelog

sets the Sec-Fetch-Dest request header to document in the case the AUT iframe is making a request. This is to better simulate top when the experimentalModifyObstructiveThirdPartyCode flag is enabled.

Additional details

The goal of this change is to better simulate top from the AUT iframe by setting the Sec-Fetch-Dest metadata header to document when the AUT iframe itself is making a request and the Sec-Fetch-Dest is iframe. This change it the proxy allows the AUT iframe to appear more like top. This should NOT effect nested iframes in the AUT and only impacts the AUT iframe, which we can safely assume would be top otherwise.

Steps to test

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 8, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Sep 8, 2022



Test summary

4755 0 370 0Flakiness 2


Run details

Project cypress
Status Passed
Commit 5365130
Started Sep 9, 2022 8:17 PM
Ended Sep 9, 2022 8:31 PM
Duration 14:25 💡
OS Linux Debian - 11.3
Browser Electron 102

View run in Cypress Dashboard ➡️


Flakiness

config_env.cy.ts Flakiness
1 cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary
commands/network_requests.cy.ts Flakiness
1 cy.origin network requests > .request() to secondary origin

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Authentication is 403 forbidden in Edge and Electron in Cypress 10.6.0
4 participants