-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add MaybeSimulateSecHeaders code to prevent 403 issues with google #23720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for taking the time to open a PR!
|
AtofStryker
requested review from
chrisbreiding,
mschile,
BlueWinds,
emilyrohrbough,
mjhenkes and
ryanthemanuel
September 8, 2022 15:00
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
4 tasks
chrisbreiding
approved these changes
Sep 8, 2022
mschile
approved these changes
Sep 9, 2022
AtofStryker
force-pushed
the
feat/simulate-sec-dest-header
branch
from
September 9, 2022 18:06
e45ac0b
to
2f6f13a
Compare
AtofStryker
force-pushed
the
feat/simulate-sec-dest-header
branch
from
September 9, 2022 19:05
2f6f13a
to
5365130
Compare
emilyrohrbough
approved these changes
Sep 9, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
sets the
Sec-Fetch-Dest
request header todocument
in the case the AUT iframe is making a request. This is to better simulate top when theexperimentalModifyObstructiveThirdPartyCode
flag is enabled.Additional details
The goal of this change is to better simulate top from the AUT iframe by setting the
Sec-Fetch-Dest
metadata header todocument
when the AUT iframe itself is making a request and theSec-Fetch-Dest
isiframe
. This change it the proxy allows the AUT iframe to appear more like top. This should NOT effect nested iframes in the AUT and only impacts the AUT iframe, which we can safely assume would be top otherwise.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?