-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: various flaky + a11y improvements #23745
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
@@ -19,6 +19,7 @@ | |||
class="mr-16px min-w-26px w-26px" | |||
:class="{ 'filter grayscale': browser.disabled || !browser.isVersionSupported }" | |||
:src="allBrowsersIcons[browser.displayName] || allBrowsersIcons.generic" | |||
:alt="browser.displayName || ''" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think of making this always empty? It announces "Chrome, chrome" when it's right next to the existing browser name, so I think it's fair to call the browser icons decorative.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh good call!
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
User facing changelog
Fixes some alt tags and aria attributes.
Additional details
This PR does several things!
percy-finalize
even though all the other jobs have finishedafterEach
and the test itself already had skippedpercySnapshot
commands.Steps to test
alt
tags oraria-hidden
In any case, for the purposes of this PR, the step to test is just to confirm that the percy finalize step succeeded on retry in this build where I forced an error by adding a typo to the first script
How has the user experience changed?
No visual changes. Modest improvements to user experience for screenreader users via alt/aria-hidden attributes
PR Tasks
cypress-documentation
?type definitions
?