Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: various flaky + a11y improvements #23745

Merged
merged 24 commits into from
Sep 13, 2022

Conversation

rachelruderman
Copy link
Contributor

@rachelruderman rachelruderman commented Sep 9, 2022

  • Closes N/A

User facing changelog

Fixes some alt tags and aria attributes.

Additional details

This PR does several things!

  1. Adds a single retry to the percy finalize step. We'll see if this helps with the percy flakiness where it times out during percy-finalize even though all the other jobs have finished
  2. Skips flaky tooltip visual test. The visual test in question was actually redundant, as it lived in an afterEach and the test itself already had skipped percySnapshot commands.
  3. Fixes some alt tags and aria attributes while I was in the neighborhood

Steps to test

  1. CI is green 🟢
  2. When run locally, only shows one type of a11y violation in the test runner (color contrast). No a11y violations related to alt tags or aria-hidden
  3. As far as the percy finalize retry is concerned, the change is based on the following hypothesis:

When we've seen the yarn percy build:finalize command hang, the build DOES exist in Percy (as verified by navigating to it on the Percy website). Theoretically, since the build exists and all the jobs succeeded, simply retrying the step has a good chance of going through the second time. It may not work... but it also may work! We'll see.

In any case, for the purposes of this PR, the step to test is just to confirm that the percy finalize step succeeded on retry in this build where I forced an error by adding a typo to the first script

How has the user experience changed?

No visual changes. Modest improvements to user experience for screenreader users via alt/aria-hidden attributes

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 9, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Sep 9, 2022



Test summary

40020 0 3359 0Flakiness 1


Run details

Project cypress
Status Passed
Commit c51b2d8
Started Sep 13, 2022 4:24 PM
Ended Sep 13, 2022 4:40 PM
Duration 15:28 💡
OS Linux Debian - 11.3
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/e2e/origin/commands/aliasing.cy.ts Flakiness
1 cy.origin aliasing > .as() > supports dom elements inside origin

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@rachelruderman rachelruderman changed the title a11y improvements chore: various flaky improvements Sep 9, 2022
@rachelruderman rachelruderman changed the title chore: various flaky improvements chore: various flaky + a11y improvements Sep 9, 2022
@rachelruderman rachelruderman marked this pull request as ready for review September 9, 2022 15:33
@@ -19,6 +19,7 @@
class="mr-16px min-w-26px w-26px"
:class="{ 'filter grayscale': browser.disabled || !browser.isVersionSupported }"
:src="allBrowsersIcons[browser.displayName] || allBrowsersIcons.generic"
:alt="browser.displayName || ''"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of making this always empty? It announces "Chrome, chrome" when it's right next to the existing browser name, so I think it's fair to call the browser icons decorative.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good call!

@rachelruderman rachelruderman merged commit 1190c3e into develop Sep 13, 2022
@rachelruderman rachelruderman deleted the skip-more-flake-issue-23436 branch September 13, 2022 19:02
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 27, 2022

Released in 10.9.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.9.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Sep 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants