fix: allow more than 20 sessions to be created in a single test #24379
Conversation
|
Thanks for taking the time to open a PR!
|
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
…n-checking-redirect-limits
| @@ -765,7 +765,6 @@ describe('src/cy/commands/navigation', () => { | |||
| }) | |||
|
|
|||
| cy.visit('fixtures/redirection-loop-a.html') | |||
| cy.get('div').should('contain', 'this should fail?') | |||
There was a problem hiding this comment.
Previously removing this line would allow the test to not throw the failure. I made a couple of changes below to now not require this line.
|
@mjhenkes I think this is officially the longest branch name I've ever seen. |
| @@ -315,6 +315,11 @@ const stabilityChanged = async (Cypress, state, config, stable) => { | |||
| const onPageLoadErr = (err) => { | |||
| state('onPageLoadErr', null) | |||
|
|
|||
| // If the error thrown is a cypress error, return it instead of throwing a cross origin error. | |||
| if ($errUtils.isCypressErr(err)) { | |||
There was a problem hiding this comment.
I wonder if this will fix the error I've been seeing in my branch! Hoping it will 😄
Co-authored-by: Bill Glesias <bglesias@gmail.com>
…n-checking-redirect-limits
mjhenkes
deleted the
matth/fix/ignore-visiting-about-blank-when-checking-redirect-limits
branch
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
User facing changelog
Additional details
Visiting about blank more than 20 times when creating a session would trigger the redirect warning logic.
Steps to test
See the added test.
How has the user experience changed?
Tests with more than 20 sessions no longer fail.
PR Tasks
cypress-documentation?type definitions?