Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make error more inclusive of future cypress versions #24559

Merged
merged 6 commits into from Nov 8, 2022

Conversation

lmiller1990
Copy link
Member

@lmiller1990 lmiller1990 commented Nov 7, 2022

I tried installing Cypress 11 in a Cypress 9 project. If you open it in global mode, it says "You are in global mode. Please install Cypress 10 in your project to migrate".

I tested it out, I was able to migrate from Cypress 9 to Cypress 11 using the migration wizard.

We didn't really discuss if this should work (eg; should we force users to Cypress 10, then Cypress 11?) but it works great as is, I say we just make the minimal change, which is to update the language in the message.

@cypress-bot
Copy link

cypress-bot bot commented Nov 7, 2022

Thanks for taking the time to open a PR!

Copy link
Contributor

@marktnoonan marktnoonan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, definitely not intending that people upgrade to 10 separately - 9.x -> 11.0 is expected to be fine.

Suggested a change to the line below as well.

packages/errors/src/errors.ts Outdated Show resolved Hide resolved
@cypress
Copy link

cypress bot commented Nov 7, 2022



Test summary

46457 0 4319 0Flakiness 17


Run details

Project cypress
Status Passed
Commit fce1b51
Started Nov 8, 2022 5:55 AM
Ended Nov 8, 2022 6:14 AM
Duration 18:08 💡
OS Linux Debian -
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/e2e/origin/cookie_behavior.cy.ts Flakiness
1 ... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
2 ... > same site / cross origin > fetch > sets same-site cookies if "include" credentials option is specified from request, but does not attach same-site cookies to request by default (same-origin)
3 ... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
4 ... > same site / cross origin > fetch > sets same-site cookies if "include" credentials option is specified from request, but does not attach same-site cookies to request by default (same-origin)
5 ... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
This comment includes only the first 5 flaky tests. See all 17 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@lmiller1990
Copy link
Member Author

Finally, this is green. This was a bit painful... apparently missing a newline here: fce1b51 was causing CI to fail, without actually making it obvious why. Also, it wasn't failing locally.

@lmiller1990 lmiller1990 merged commit a8a9c78 into develop Nov 8, 2022
81 of 83 checks passed
@lmiller1990 lmiller1990 deleted the lmiller/correct-version-in-error branch November 8, 2022 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants