Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sessions): correct when page is cleared in cy.session() #24563

Merged
merged 7 commits into from Nov 15, 2022

Conversation

emilyrohrbough
Copy link
Member

@emilyrohrbough emilyrohrbough commented Nov 7, 2022

User facing changelog

The session command no longer clears the page between setup and validation and will now always clear the page at the end of the command when test isolation is on. Fixes #21397.

How has the user experience changed?

The session command no longer clear the page between setup and validation and will now alway clear the page at the end of the command when test isolation is on.

PR Tasks

@cypress-bot
Copy link

cypress-bot bot commented Nov 7, 2022

Thanks for taking the time to open a PR!

@emilyrohrbough emilyrohrbough changed the title fix(sessions): remove page clear between setup and validate and alway… fix(sessions): correct when page is cleared in cy.session() Nov 7, 2022
@cypress
Copy link

cypress bot commented Nov 7, 2022



Test summary

46515 0 4326 0Flakiness 22


Run details

Project cypress
Status Passed
Commit d72dd5a
Started Nov 14, 2022 3:58 PM
Ended Nov 14, 2022 4:17 PM
Duration 18:56 💡
OS Linux Debian -
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/e2e/origin/cookie_behavior.cy.ts Flakiness
1 ... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
2 ... > same site / cross origin > fetch > sets same-site cookies if "include" credentials option is specified from request, but does not attach same-site cookies to request by default (same-origin)
3 ... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
4 ... > same site / cross origin > fetch > sets same-site cookies if "include" credentials option is specified from request, but does not attach same-site cookies to request by default (same-origin)
5 ... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
This comment includes only the first 5 flaky tests. See all 22 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

emilyrohrbough and others added 2 commits November 10, 2022 08:43
# Conflicts:
#	packages/driver/cypress/e2e/commands/sessions/sessions.cy.js
#	packages/driver/src/cy/commands/sessions/index.ts
@AtofStryker AtofStryker self-requested a review November 10, 2022 17:16
@@ -194,13 +194,18 @@ const getPostMessageLocalStorage = (specWindow, origins): Promise<any[]> => {
}

function navigateAboutBlank (session: boolean = true) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
function navigateAboutBlank (session: boolean = true) {
function maybeNavigateAboutBlank (session: boolean = true) {

@emilyrohrbough emilyrohrbough merged commit f73bb46 into develop Nov 15, 2022
81 of 83 checks passed
@emilyrohrbough emilyrohrbough deleted the fix-session-clearing branch November 15, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sessions] Evaluate & Update Clear Page System Event Logs
4 participants