Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only save session if validation succeeds #24565

Merged
merged 6 commits into from Nov 10, 2022

Conversation

chrisbreiding
Copy link
Contributor

@chrisbreiding chrisbreiding commented Nov 7, 2022

User facing changelog

  • Sessions will no longer be stored if validation fails

Additional details

Steps to test

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [N/A] Has a PR for user-facing changes been opened in cypress-documentation?
  • [N/A] Have API changes been updated in the type definitions?

@cypress-bot
Copy link

cypress-bot bot commented Nov 7, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Nov 7, 2022



Test summary

4179 0 1088 0Flakiness 1


Run details

Project cypress
Status Passed
Commit ca450fe
Started Nov 7, 2022 9:58 PM
Ended Nov 7, 2022 10:14 PM
Duration 16:15 💡
OS Linux Debian -
Browser WebKit 16

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/commands/xhr.cy.js Flakiness
1 src/cy/commands/xhr > abort > aborts xhrs currently in flight

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@chrisbreiding chrisbreiding merged commit 7c9a0c6 into develop Nov 10, 2022
80 of 83 checks passed
@chrisbreiding chrisbreiding deleted the issue-24208-store-after-validation branch November 10, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only Save Session after Successful Validation
3 participants