Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add warned command state to use for recreated sessions #24592

Merged
merged 14 commits into from Nov 16, 2022

Conversation

emilyrohrbough
Copy link
Member

User facing changelog

Visually warn in the Command Log when cy.session() failed to restore a session and it was recreated to surface to users potential issues with their setup and validation. Resolves #24207.

How has the user experience changed?

Before After
Screen Shot 2022-11-08 at 9 23 20 AM Screen Shot 2022-11-08 at 9 07 15 AM

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [TODO] Has a PR for user-facing changes been opened in cypress-documentation?
  • [n/a] Have API changes been updated in the type definitions?

@cypress-bot
Copy link

cypress-bot bot commented Nov 8, 2022

Thanks for taking the time to open a PR!

@emilyrohrbough emilyrohrbough added the topic: session Issues when using session command label Nov 8, 2022
@emilyrohrbough emilyrohrbough self-assigned this Nov 8, 2022
emilyrohrbough and others added 3 commits November 10, 2022 08:13
# Conflicts:
#	packages/driver/src/cy/commands/sessions/index.ts
#	packages/driver/src/cy/commands/sessions/utils.ts
#	packages/reporter/src/sessions/sessions-model.ts
#	packages/reporter/src/sessions/sessions.tsx
@AtofStryker AtofStryker self-requested a review November 10, 2022 17:16
Copy link
Collaborator

@ryanthemanuel ryanthemanuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one small comment!

packages/reporter/src/commands/commands.scss Outdated Show resolved Hide resolved
@emilyrohrbough emilyrohrbough merged commit 8d85c80 into develop Nov 16, 2022
81 of 83 checks passed
@emilyrohrbough emilyrohrbough deleted the sessions-show-recreate-as-warning branch November 16, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: session Issues when using session command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Surface "recreated" session visually
3 participants