Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vite-dev-server hoisting issue in binary #24599

Merged
merged 1 commit into from Nov 8, 2022

Conversation

ZachJW34
Copy link
Contributor

@ZachJW34 ZachJW34 commented Nov 8, 2022

User facing changelog

N/A

Additional details

debug was the only package not being hoisted, causing node resolution to go haywire. Tested with a local binary, but this PR should have the binaries built as well.

Steps to test

Have to test using the binary against an app setup with Cypress CT + vite

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link

cypress-bot bot commented Nov 8, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Nov 8, 2022



Test summary

598 4 45 0Flakiness 7


Run details

Project cypress
Status Failed
Commit 4c2f6b9
Started Nov 8, 2022 8:16 PM
Ended Nov 8, 2022 8:32 PM
Duration 16:01 💡
OS Windows 10.0.17763
Browser Chrome 107

View run in Cypress Dashboard ➡️


Failures

Run group: app-e2e (Windows, Chrome )
cypress\e2e\subscriptions\configChange-subscription.cy.ts Failed
1 configChange subscription > on runner page > responds to configChange event and re-runs spec
Run group: launchpad-e2e (Windows, Chrome )
cypress\e2e\top-nav-launchpad.cy.ts Failed
1 ... > global mode > shows "continue" button after login if project selected
cypress\e2e\config-warning.cy.ts Failed
1 component testing dependency warnings > does not show warning for project with supported dependencies
cypress\e2e\error-handling.cy.ts Failed
1 ... > automatically sources webpack.config.js

Flakiness

cypress\e2e\migration.cy.ts Flakiness
1 Full migration flow for each project > completes journey for migration-e2e-component-with-json-files
2 Full migration flow for each project > completes journey for migration-e2e-legacy-plugins-throws-error and recovers
cypress\e2e\specs.cy.ts Flakiness
1 ... > shows No Specs page with specPattern from config
cypress\e2e\scaffold-component-testing.cy.ts Flakiness
1 scaffolding component testing > create-react-app > scaffolds component testing for Create React App v5 project
2 scaffolding component testing > svelte-webpack-unconfigured > Scaffolds component testing for Svelte using webpack
This comment includes only the first 5 flaky tests. See all 7 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@ZachJW34 ZachJW34 marked this pull request as ready for review November 8, 2022 20:10
Copy link
Collaborator

@ryanthemanuel ryanthemanuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this locally and it works great. Thanks for getting this done!

Copy link
Contributor

@astone123 astone123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the binary and it worked for me 👍🏻

@rockindahizzy rockindahizzy merged commit 2513bea into develop Nov 8, 2022
112 of 123 checks passed
@rockindahizzy rockindahizzy deleted the zachw/fix-vite-hoisting-issue branch November 8, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

None yet

4 participants