Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test isolation config validation #24604

Merged
merged 1 commit into from Nov 9, 2022

Conversation

emilyrohrbough
Copy link
Member

User facing changelog

Fix testIsolation configuration validation to allow configuration updates without restarting Cypress. Fixes #24497.

Steps to test

Open project with experimentalSessionAndOrigin=true. Modify the configuration file and see error. (Example in issue).

How has the user experience changed?

Able to update and/all configuration in their cypress.config.js file and it successfully reflects in the App.

PR Tasks

  • [n/a] Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [n/a] Has a PR for user-facing changes been opened in cypress-documentation?
  • [n/a] Have API changes been updated in the type definitions?

@cypress-bot
Copy link

cypress-bot bot commented Nov 8, 2022

Thanks for taking the time to open a PR!

@emilyrohrbough emilyrohrbough merged commit 547b700 into develop Nov 9, 2022
83 of 86 checks passed
@emilyrohrbough emilyrohrbough deleted the fix-test-load-err-w-test-isolation branch November 9, 2022 14:36
@cypress
Copy link

cypress bot commented Nov 9, 2022

@skjnldsv
Copy link

skjnldsv commented Nov 9, 2022

@emilyrohrbough is this going to be backported to 10.x.x ? :)
Thanks for fixing this! 🙇‍♀️

EDIT: it's in 11.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Incorrect Configuration error with testIsolation setting when experimentalSessionAndOrigin is true
4 participants