Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: junit reporters crashing on failed asserts #24677

Merged
merged 7 commits into from Nov 14, 2022

Conversation

ryanthemanuel
Copy link
Collaborator

@ryanthemanuel ryanthemanuel commented Nov 14, 2022

User facing changelog

Cypress will no longer crash when using the junit reporter on failed asserts

Additional details

It appears that we have a delicate ordering for our logic to override mocha resolution. We need to ensure that it is loaded at the appropriate time or things get loaded incorrectly. I tried moving that loading around to various places in the code base, to no avail. The only thing I could get to work was to ensure that the dependencies in this PR don't defer when they load their dependencies. It's not ideal, but we now have a system test for this scenario that should prevent things like this in the future.

Steps to test

Write a failing test and use the junit reporter

How has the user experience changed?

cypress run no longer crashes when an assert fails

PR Tasks

  • Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@cypress
Copy link

cypress bot commented Nov 14, 2022

@ryanthemanuel ryanthemanuel marked this pull request as ready for review November 14, 2022 15:20
pec -- afterEach hooks -- runs this -- after each hook (failed).png
- /XXX/XXX/XXX/cypress/screenshots/simple_failing_hook.cy.js/simple failing hook s (1280x720)
- /XXX/XXX/XXX/cypress/screenshots/simple_failing_hook.cy.js/simple failing hook s (2560x1440)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would this change increase the snapshot size? This seems quite large for a default snapshot size.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's the size of the launched browser

@ryanthemanuel ryanthemanuel merged commit 9b1d05d into develop Nov 14, 2022
81 of 83 checks passed
@ryanthemanuel ryanthemanuel deleted the ryanm/fix/reporters branch November 14, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cypress v11 cypress run crashes when assertion in test fails
5 participants