Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue with loading typescript and v8 snapshot #24684

Merged
merged 2 commits into from Nov 15, 2022

Conversation

ryanthemanuel
Copy link
Collaborator

User facing changelog

N/A

Additional details

No new functional fixes, but the combination of #24677 and #24675 exposed a timing problem. Specifically typescript is no longer detected in a consumer project. require.resolve was fixed on this PR however there was a scenario that was missed to ensure that whenever we are calling require.resolve the original version is called when paths are provided.

Steps to test

Use the binary from this PR and try and migrate a project that uses typescript from 9 to 11 and ensure that typescript is properly detected

How has the user experience changed?

n/a

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@cypress-bot
Copy link

cypress-bot bot commented Nov 14, 2022

Thanks for taking the time to open a PR!

@ryanthemanuel ryanthemanuel marked this pull request as ready for review November 14, 2022 23:49
@cypress
Copy link

cypress bot commented Nov 15, 2022



Test summary

561 8 42 51Flakiness 9


Run details

Project cypress
Status Failed
Commit 9e428e4
Started Nov 15, 2022 2:54 PM
Ended Nov 15, 2022 3:09 PM
Duration 15:22 💡
OS Windows 10.0.17763
Browser Chrome 107

View run in Cypress Dashboard ➡️


Failures

Run group: launchpad-e2e (Windows, Chrome )
cypress\e2e\migration.cy.ts Failed
1 global mode > migrates 2 projects in global mode
Run group: app-e2e (Windows, Chrome )
cypress\e2e\runner\sessions.ui.cy.ts Failed
1 ... > setup has failing Cypress command
cypress\e2e\cypress-in-cypress.cy.ts Failed
1 Cypress in Cypress > handles automation disconnects in component
cypress\e2e\runner\reporter-ct-webpack.uncaught-errors.cy.ts Failed
1 uncaught errors
cypress\e2e\runner\retries.mochaEvents.cy.ts Failed
1 src/cypress/runner retries mochaEvents > simple retry
cypress\e2e\subscriptions\configChange-subscription.cy.ts Failed
1 configChange subscription > on config page > responds to configChange event when viewport is changed
cypress\e2e\specs_list_component.cy.ts Failed
1 App: Spec List (Component) > opens spec pattern modal
cypress\e2e\runner\pluginEvents.cy.ts Failed
1 plugin events > supports "before:run" event

Flakiness

cypress\e2e\migration.cy.ts Flakiness
1 Full migration flow for each project > completes journey for migration-component-testing-defaults
2 Full migration flow for each project > completes journey for migration-e2e-component-with-json-files
cypress\e2e\scaffold-component-testing.cy.ts Flakiness
1 scaffolding component testing > vuecli4vue2 > scaffolds component testing for Vue CLI 4 w/ Vue 2 project
2 scaffolding component testing > react-vite-ts-unconfigured > scaffolds component testing for React and Vite
3 scaffolding component testing > vue3-vite-ts-unconfigured > scaffolds component testing for Vue 3 and Vite
This comment includes only the first 5 flaky tests. See all 9 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@ryanthemanuel ryanthemanuel merged commit cea2664 into develop Nov 15, 2022
111 of 121 checks passed
@ryanthemanuel ryanthemanuel deleted the ryanm/fix/typescript-issue branch November 15, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

None yet

3 participants